linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@redhat.com>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] cthon04: add "nowarn" option to nroff.in tables
Date: Thu, 27 Jan 2011 21:11:11 -0500	[thread overview]
Message-ID: <20110127211111.4a133949@corrin.poochiereds.net> (raw)
In-Reply-To: <1296154174-13076-4-git-send-email-steved@redhat.com>

On Thu, 27 Jan 2011 13:49:34 -0500
Steve Dickson <steved@redhat.com> wrote:

> From: Jeff Layton <jlayton@redhat.com>
> 
> This prevents the tbl preprocessor from stuffing warnings into the
> resulting file, which subsequently can make nroff spew warnings like
> this on stderr:
>     warning: file `nroff.in', around line 47:
> 	  table wider than line width
> 
> Unfortunately, I'm not sure how non-gnu tbl programs will react to
> this option, so YMMV.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> Signed-off-by: Steve Dickson <steved@redhat.com>
> ---
>  general/nroff.in |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/general/nroff.in b/general/nroff.in
> index 5722733..ff57200 100644
> --- a/general/nroff.in
> +++ b/general/nroff.in
> @@ -38,12 +38,12 @@ A bubble sort of integers.
>  A prime number generator.
>  .LP
>  .TS
> -center;
> - c|c|c s|
> - c|c|c s|
> - c|c|c s|
> - c|c|c s|
> -|l|n|n|n|.
> +center nowarn;
> + c|c|c s|c s|
> + c|c|c s|c s|
> + c|c|c s|c s|
> + c|c|c s|c s|
> +|l|n|n|n|n|n|.
>  	_	_	_	_	_
>  .sp 4p
>  	Matrix Inversion	Bubble Sort	Prime Numbers

It looks like this patch reverts the change in patch 2?

If patch 2 prevents the warning and the stat.c now skips lines that
it's not looking for, it might be better to just drop this patch since
"nowarn" might cause non-gnu tbl programs to fail.

-- 
Jeff Layton <jlayton@redhat.com>

      reply	other threads:[~2011-01-28  2:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 18:49 [PATCH 0/3] Connectathon: Remove warning from general tests Steve Dickson
2011-01-27 18:49 ` [PATCH 1/3] Make the stat command ignore lines that it is not looking for Steve Dickson
2011-01-27 18:49 ` [PATCH 2/3] Make the tbl table smaller to avoid a warning about line width Steve Dickson
2011-01-27 18:49 ` [PATCH 3/3] cthon04: add "nowarn" option to nroff.in tables Steve Dickson
2011-01-28  2:11   ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110127211111.4a133949@corrin.poochiereds.net \
    --to=jlayton@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steved@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).