From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:3426 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963Ab1A1CHo (ORCPT ); Thu, 27 Jan 2011 21:07:44 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0S27iNc015184 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 27 Jan 2011 21:07:44 -0500 Date: Thu, 27 Jan 2011 21:11:11 -0500 From: Jeff Layton To: Steve Dickson Cc: Linux NFS Mailing list Subject: Re: [PATCH 3/3] cthon04: add "nowarn" option to nroff.in tables Message-ID: <20110127211111.4a133949@corrin.poochiereds.net> In-Reply-To: <1296154174-13076-4-git-send-email-steved@redhat.com> References: <1296154174-13076-1-git-send-email-steved@redhat.com> <1296154174-13076-4-git-send-email-steved@redhat.com> Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Thu, 27 Jan 2011 13:49:34 -0500 Steve Dickson wrote: > From: Jeff Layton > > This prevents the tbl preprocessor from stuffing warnings into the > resulting file, which subsequently can make nroff spew warnings like > this on stderr: > warning: file `nroff.in', around line 47: > table wider than line width > > Unfortunately, I'm not sure how non-gnu tbl programs will react to > this option, so YMMV. > > Signed-off-by: Jeff Layton > Signed-off-by: Steve Dickson > --- > general/nroff.in | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/general/nroff.in b/general/nroff.in > index 5722733..ff57200 100644 > --- a/general/nroff.in > +++ b/general/nroff.in > @@ -38,12 +38,12 @@ A bubble sort of integers. > A prime number generator. > .LP > .TS > -center; > - c|c|c s| > - c|c|c s| > - c|c|c s| > - c|c|c s| > -|l|n|n|n|. > +center nowarn; > + c|c|c s|c s| > + c|c|c s|c s| > + c|c|c s|c s| > + c|c|c s|c s| > +|l|n|n|n|n|n|. > _ _ _ _ _ > .sp 4p > Matrix Inversion Bubble Sort Prime Numbers It looks like this patch reverts the change in patch 2? If patch 2 prevents the warning and the stat.c now skips lines that it's not looking for, it might be better to just drop this patch since "nowarn" might cause non-gnu tbl programs to fail. -- Jeff Layton