From: Karel Zak <kzak@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] mount: move generic functions to utils.c and network.c
Date: Tue, 8 Feb 2011 17:08:23 +0100 [thread overview]
Message-ID: <20110208160823.GA21408@nb.net.home> (raw)
In-Reply-To: <D42D29E5-82B4-4786-BB0C-D2672A58F522@oracle.com>
On Tue, Feb 08, 2011 at 10:43:23AM -0500, Chuck Lever wrote:
> Nice work, just a few nits so far.
I'll send updated version later. Thanks for your feedback.
> I'll wait for utils-linux
> 2.19... and we have NFS Connectathon (http://www.connectathon.org)
> in a couple of weeks, so it will be March before I can spend some
> quality time with this.
>
> Also, I'm cleaning up a version of parse_opt.c and token.c for you,
> if you want to include these in libmount at some point.
The library already has some code for mount options parsing, but there
is not code to create a list from parsed mount options. The library
already uses struct list_head (originally probably from e2fsprogs
and Linux kernel, see include/list.h in util-linux), so maybe we can
use it for mount options too.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
next prev parent reply other threads:[~2011-02-08 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 13:45 mount.nfs libmount support Karel Zak
2011-02-08 13:45 ` [PATCH 1/2] mount: move generic functions to utils.c and network.c Karel Zak
2011-02-08 15:43 ` Chuck Lever
2011-02-08 16:08 ` Karel Zak [this message]
2011-02-15 0:08 ` Chuck Lever
2011-02-08 13:45 ` [PATCH 2/2] mount: add --enable-libmount-mount Karel Zak
2011-02-08 15:56 ` Chuck Lever
2011-02-09 5:25 ` mount.nfs libmount support NeilBrown
-- strict thread matches above, loose matches on Subject: below --
2011-03-03 13:43 mount.nfs libmount support (v2) Karel Zak
2011-03-03 13:43 ` [PATCH 1/2] mount: move generic functions to utils.c and network.c Karel Zak
2011-03-14 13:58 mount.nfs libmount support (v3) Karel Zak
2011-03-14 13:58 ` [PATCH 1/2] mount: move generic functions to utils.c and network.c Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208160823.GA21408@nb.net.home \
--to=kzak@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).