From: "J. Bruce Fields" <bfields@redhat.com>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: fix decode_cb_sequence4resok
Date: Wed, 23 Feb 2011 09:29:57 -0800 [thread overview]
Message-ID: <20110223172957.GA6238@pad.home.fieldses.org> (raw)
In-Reply-To: <4D653F12.8090101@panasas.com>
On Wed, Feb 23, 2011 at 09:08:34AM -0800, Benny Halevy wrote:
> On 2011-02-23 08:48, Chuck Lever wrote:
> >
> > On Feb 22, 2011, at 2:43 PM, Benny Halevy wrote:
> >
> >> Fix bug introduced in patch
> >> 85a56480 NFSD: Update XDR decoders in NFSv4 callback client
> >>
> >> Although decode_cb_sequence4resok ignores highest slotid and target highest slotid
> >> it must account for their space in their xdr stream when calling xdr_inline_decode
> >
> > The real problem is that decoding for the next operation in the compound will start too early in the buffer, because we didn't account for the ignored 8 bytes here, yes?
>
> Right on the spot.
So actually I guess there is another bug here, which is a subset of
http://wiki.linux-nfs.org/wiki/index.php/Server_4.0_and_4.1_issues#Callback_error_handling
The server should be setting the appropriate sequence flag when it
(rightly or wrongly) things that a cb reply is garbage (not sure which
flag off the top of my head), and pynfs should be insisting that the
flag be set on any further sequence flags.
--b.
next prev parent reply other threads:[~2011-02-23 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 22:43 [PATCH] NFSD: fix decode_cb_sequence4resok Benny Halevy
2011-02-23 0:11 ` J. Bruce Fields
2011-02-23 0:15 ` Benny Halevy
2011-02-23 0:24 ` J. Bruce Fields
2011-02-23 16:48 ` Chuck Lever
2011-02-23 17:08 ` Benny Halevy
2011-02-23 17:29 ` J. Bruce Fields [this message]
2011-02-23 18:07 ` Benny Halevy
2011-02-23 18:43 ` Benny Halevy
2011-02-25 0:36 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223172957.GA6238@pad.home.fieldses.org \
--to=bfields@redhat.com \
--cc=bhalevy@panasas.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).