From: Andrew Morton <akpm@linux-foundation.org>
To: roel <roel.kluin@gmail.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsd: wrong index used in inner loop
Date: Wed, 9 Mar 2011 15:42:30 -0800 [thread overview]
Message-ID: <20110309154230.66bc2c36.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D76A06A.4090405@gmail.com>
On Tue, 08 Mar 2011 22:32:26 +0100
roel <roel.kluin@gmail.com> wrote:
> Index i was already used in the outer loop
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> fs/nfsd/nfs4xdr.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> Not 100% sure this one is needed but it looks suspicious.
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 1275b86..615f0a9 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -1142,7 +1142,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp,
>
> u32 dummy;
> char *machine_name;
> - int i;
> + int i, j;
> int nr_secflavs;
>
> READ_BUF(16);
> @@ -1215,7 +1215,7 @@ nfsd4_decode_create_session(struct nfsd4_compoundargs *argp,
> READ_BUF(4);
> READ32(dummy);
> READ_BUF(dummy * 4);
> - for (i = 0; i < dummy; ++i)
> + for (j = 0; j < dummy; ++j)
> READ32(dummy);
> break;
> case RPC_AUTH_GSS:
ooh, big bug.
I wonder why it was not previously detected at runtime. Perhaps
nr_secflavs is always 1.
afacit this bug will allow a well-crafted packet to cause an
infinite-until-it-oopses loop in the kernel.
next prev parent reply other threads:[~2011-03-09 23:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 21:32 [PATCH] nfsd: wrong index used in inner loop roel
2011-03-09 0:49 ` J. Bruce Fields
2011-03-11 4:13 ` Mi Jinlong
2011-03-14 22:22 ` J. Bruce Fields
2011-03-14 23:52 ` Trond Myklebust
2011-03-16 22:55 ` J. Bruce Fields
2011-03-15 2:31 ` Mi Jinlong
2011-03-17 17:52 ` J. Bruce Fields
2011-03-09 23:42 ` Andrew Morton [this message]
2011-03-10 18:08 ` J. Bruce Fields
2011-03-11 3:52 ` Mi Jinlong
2011-03-14 19:35 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309154230.66bc2c36.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).