From: "J. Bruce Fields" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
Bryan Schumaker <bjschuma@netapp.com>,
Chuck Lever <chuck.lever@oracle.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Use of READDIRPLUS on large directories
Date: Thu, 17 Mar 2011 13:18:31 -0400 [thread overview]
Message-ID: <20110317171831.GA30180@fieldses.org> (raw)
In-Reply-To: <20110317094019.23f31f53@notabene.brown>
On Thu, Mar 17, 2011 at 09:40:19AM +1100, NeilBrown wrote:
> On Wed, 16 Mar 2011 17:42:35 -0400 Trond Myklebust
> <Trond.Myklebust@netapp.com> wrote:
>
>
> > > So it is obvious that there is sometimes value in using readdirplus,
> > > it is equally obvious that there is sometimes a cost.
> > >
> > > Switching the default from "not paying the cost when it is big" to
> > > "always paying the cost" is wrong.
> >
> > That's what the nordirplus mount flag is for. Keeping an arbitrary limit
> > in the face of evidence that it is hurting is equally wrong.
> >
>
> If people didn't need 'nordirplus' previously to get acceptable
> performance, and do need it now, then that is a regression.
Agreed.
Unfortunately, reversion at this point would also be a regression for a
different group of folks. A smaller one, since *their* problem was
fixed only more recently, but still there's probably no sensible way out
of this but forwards....
--b.
next prev parent reply other threads:[~2011-03-17 17:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 4:55 Use of READDIRPLUS on large directories NeilBrown
2011-03-16 12:30 ` peter.staubach
2011-03-16 13:50 ` Trond Myklebust
2011-03-16 21:40 ` NeilBrown
2011-03-17 0:55 ` NeilBrown
2011-03-17 17:44 ` J. Bruce Fields
2011-03-18 4:27 ` NeilBrown
2011-03-16 13:43 ` Chuck Lever
2011-03-16 14:14 ` Bryan Schumaker
2011-03-16 14:20 ` Trond Myklebust
2011-03-16 21:30 ` NeilBrown
2011-03-16 21:42 ` Trond Myklebust
2011-03-16 22:40 ` NeilBrown
2011-03-17 17:18 ` J. Bruce Fields [this message]
2011-04-04 20:14 ` Bryan Schumaker
2011-04-05 12:20 ` NeilBrown
2011-04-07 14:28 ` Bryan Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317171831.GA30180@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=bjschuma@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).