* [patch] nfs: lock() vs unlock() typo
@ 2011-03-20 11:22 Dan Carpenter
2011-03-20 12:54 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-03-20 11:22 UTC (permalink / raw)
To: Trond Myklebust; +Cc: linux-nfs, viro, kernel-janitors
These should be spin_unlock() instead of spin_lock(). It's a typo.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/fs/nfs/namespace.c b/fs/nfs/namespace.c
index c0b8344..bf1c680 100644
--- a/fs/nfs/namespace.c
+++ b/fs/nfs/namespace.c
@@ -98,7 +98,7 @@ rename_retry:
namelen--;
buflen -= namelen;
if (buflen < 0) {
- spin_lock(&dentry->d_lock);
+ spin_unlock(&dentry->d_lock);
rcu_read_unlock();
goto Elong;
}
@@ -108,7 +108,7 @@ rename_retry:
rcu_read_unlock();
return end;
Elong_unlock:
- spin_lock(&dentry->d_lock);
+ spin_unlock(&dentry->d_lock);
rcu_read_unlock();
if (read_seqretry(&rename_lock, seq))
goto rename_retry;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] nfs: lock() vs unlock() typo
2011-03-20 11:22 [patch] nfs: lock() vs unlock() typo Dan Carpenter
@ 2011-03-20 12:54 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2011-03-20 12:54 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Trond Myklebust, linux-nfs, kernel-janitors
On Sun, Mar 20, 2011 at 02:22:07PM +0300, Dan Carpenter wrote:
> These should be spin_unlock() instead of spin_lock(). It's a typo.
Gyah... Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-20 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-20 11:22 [patch] nfs: lock() vs unlock() typo Dan Carpenter
2011-03-20 12:54 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).