* nfs4.1 locking broken
[not found] <201103252328.p2PNSVRY013346@pop.test.fieldses.org>
@ 2011-03-26 2:34 ` J. Bruce Fields
2011-03-29 3:22 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: J. Bruce Fields @ 2011-03-26 2:34 UTC (permalink / raw)
To: Trond Myklebust, William A.(Andy) Adamson; +Cc: linux-nfs
Commit 114f64b5f24abac33a42f4f1856eb3a9766d497e "NFSv4: remove duplicate
clientid in struct nfs_client" breaks locking over 4.1; from a cthon
run:
On Fri, Mar 25, 2011 at 07:28:31PM -0400, J. Bruce Fields wrote:
> Starting LOCKING tests: test directory /mnt/TMP (arg: -f)
>
> Testing native post-LFS locking
>
> Creating parent/child synchronization pipes.
>
> Test #1 - Test regions of an unlocked file.
> Parent: 1.1 - F_TEST [ 0, 1] FAILED!
> Parent: **** Expected success, returned EINVAL...
> Parent: **** Probably implementation error.
>
> ** PARENT pass 1 results: 0/0 pass, 0/0 warn, 1/1 fail (pass/total).
>
> ** CHILD pass 1 results: 0/0 pass, 0/0 warn, 0/0 fail (pass/total).
> lock tests failed
I haven't figured out why.
Presumably the lock code assumed the clientid would be unset in the 4.1
case?
--b.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: nfs4.1 locking broken
2011-03-26 2:34 ` nfs4.1 locking broken J. Bruce Fields
@ 2011-03-29 3:22 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2011-03-29 3:22 UTC (permalink / raw)
To: Trond Myklebust, William A.(Andy) Adamson; +Cc: linux-nfs
And, yuck, I think this is why I let such a bad screwup get by in the
server lock code: my usual automated testing depends on booting the same
kernel to client and server, and when they saw the client failure they
gave up and as a result never hit the bad server case. Doh. Something
else to fix in my testing.
--b.
On Fri, Mar 25, 2011 at 10:34:03PM -0400, J. Bruce Fields wrote:
> Commit 114f64b5f24abac33a42f4f1856eb3a9766d497e "NFSv4: remove duplicate
> clientid in struct nfs_client" breaks locking over 4.1; from a cthon
> run:
>
> On Fri, Mar 25, 2011 at 07:28:31PM -0400, J. Bruce Fields wrote:
> > Starting LOCKING tests: test directory /mnt/TMP (arg: -f)
> >
> > Testing native post-LFS locking
> >
> > Creating parent/child synchronization pipes.
> >
> > Test #1 - Test regions of an unlocked file.
> > Parent: 1.1 - F_TEST [ 0, 1] FAILED!
> > Parent: **** Expected success, returned EINVAL...
> > Parent: **** Probably implementation error.
> >
> > ** PARENT pass 1 results: 0/0 pass, 0/0 warn, 1/1 fail (pass/total).
> >
> > ** CHILD pass 1 results: 0/0 pass, 0/0 warn, 0/0 fail (pass/total).
> > lock tests failed
>
> I haven't figured out why.
>
> Presumably the lock code assumed the clientid would be unset in the 4.1
> case?
>
> --b.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-29 3:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201103252328.p2PNSVRY013346@pop.test.fieldses.org>
2011-03-26 2:34 ` nfs4.1 locking broken J. Bruce Fields
2011-03-29 3:22 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).