From: Christoph Hellwig <hch@lst.de>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Rees <rees@citi.umich.edu>, linux-nfs@vger.kernel.org
Subject: Re: [RFC] spnfs-block: restore i_op->fallocate
Date: Wed, 30 Mar 2011 19:33:44 +0200 [thread overview]
Message-ID: <20110330173344.GA24631@lst.de> (raw)
In-Reply-To: <4D936453.2070501@panasas.com>
On Wed, Mar 30, 2011 at 07:11:47PM +0200, Benny Halevy wrote:
> Makes sense. This could also be done by adding a respective flags argument
> to fallocate and have a common wrapper function look at the file descriptor
> and call the fs fallocate, that could then get the inode rather the file.
> In other words, why copy code rather than factor it out into a common
> function?
We can discuss that _iff_ a valid use for a file-less fallocate appears
in mainline. The pnfs-block one is not. It's just a racy hack, which
opens gapping holes. Take a look what it does - it allocates block for
a client to write into directly, with absolutely zero guarantee the
block allocation actually stays around until that point.
You'll need to have some outstanding token on extent map changes like
done in CXFS or NEC's "gfs" which implemented something similar to pnfs
based on nfsv3.
next prev parent reply other threads:[~2011-03-30 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301500460-16467-1-git-send-email-bhalevy@panasas.com>
2011-03-30 15:58 ` [RFC] spnfs-block: restore i_op->fallocate Christoph Hellwig
2011-03-30 17:11 ` Benny Halevy
2011-03-30 17:33 ` Christoph Hellwig [this message]
2011-03-31 6:53 ` Benny Halevy
2011-03-31 13:53 ` Christoph Hellwig
2011-04-01 8:30 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330173344.GA24631@lst.de \
--to=hch@lst.de \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@citi.umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).