From: "J. Bruce Fields" <bfields@fieldses.org>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: "J. Bruce Fields" <bfields@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, stable@kernel.org,
akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org
Subject: Re: [105/105] nfsd4: fix oops on lock failure
Date: Tue, 19 Apr 2011 16:43:49 -0400 [thread overview]
Message-ID: <20110419204349.GB8228@fieldses.org> (raw)
In-Reply-To: <87hb9uhcre.fsf@devron.myhome.or.jp>
On Tue, Apr 19, 2011 at 05:21:57PM +0900, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>
> >> I'll start test of this patch, and see what happens.
> >
> > OK. Although filp slabs are still slightly increasing (I'm not sure yet
> > whether this is leak of filp on system). But watching before/after
> > patch, the graph of filp slabs is clearly different.
> >
> > As far as I can say patches are fine.
>
> slightly increasing was stopped at 2200-2300. filp leak seems to be fixed.
Another thing to check is whether you can always unmount the exported
filesystem on the server after running your test. So something like:
service nfs stop
unmount /exports/fs
should always succeed; if you get an inexplicable EBUSY on the final
unmount then we likely still have a leak someplace.
--b.
next prev parent reply other threads:[~2011-04-19 20:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110412143559.186613198@clark.kroah.org>
[not found] ` <87pqokx6lr.fsf@devron.myhome.or.jp>
2011-04-17 16:10 ` [105/105] nfsd4: fix oops on lock failure Linus Torvalds
2011-04-18 15:32 ` J. Bruce Fields
2011-04-18 15:42 ` J. Bruce Fields
2011-04-18 16:08 ` OGAWA Hirofumi
2011-04-18 16:10 ` OGAWA Hirofumi
2011-04-18 16:39 ` OGAWA Hirofumi
2011-04-18 16:59 ` Linus Torvalds
2011-04-18 17:16 ` J. Bruce Fields
2011-04-18 18:21 ` [stable] " Greg KH
2011-04-18 21:12 ` OGAWA Hirofumi
2011-04-19 8:21 ` OGAWA Hirofumi
2011-04-19 20:43 ` J. Bruce Fields [this message]
2011-04-19 21:17 ` OGAWA Hirofumi
[not found] ` <87aafmgcvk.fsf-x/W9pkDDSe1TgC2z9Sl/nXf5DAMn2ifp@public.gmane.org>
2011-04-19 21:33 ` J. Bruce Fields
2011-04-20 23:23 ` nfsd bugfixes for 2.6.39 J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419204349.GB8228@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bfields@redhat.com \
--cc=gregkh@suse.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).