Re: [PATCH] rpc.idmapd dies with 'I/O possible'

[Jeff Layton <jlayton@redhat.com>]

On Mon, 16 May 2011 15:38:27 +0200
Luca Giuzzi <luca.giuzzi@gmail.com> wrote:

> Dear All,
>  we have had problems on some of our machines (all Fedora 14), where
> rpc.idmapd used to die with an `I/O possible' message at (basically)
> random times. A strace suggested the issue being in nfsopen() where a
> signal type is reset before notification is disabled; a signal at just
> the right time might be the cause of the problem; see
> https://bugzilla.redhat.com/show_bug.cgi?id=684308
> I am now proposing the (trivial) patch to the list as well.
> 
> Best Regards,
>   luca giuzzi
> 
> --- nfs-utils-1.2.3/utils/idmapd/idmapd.c.orig	2011-05-13
> 16:27:08.000000000 +0200
> +++ nfs-utils-1.2.3/utils/idmapd/idmapd.c	2011-05-13 16:27:16.000000000 +0200
> @@ -778,8 +778,8 @@ nfsopen(struct idmap_client *ic)
>  	} else {
>  		event_set(&ic->ic_event, ic->ic_fd, EV_READ, nfscb, ic);
>  		event_add(&ic->ic_event, NULL);
> -		fcntl(ic->ic_dirfd, F_SETSIG, 0);
>  		fcntl(ic->ic_dirfd, F_NOTIFY, 0);
> +		fcntl(ic->ic_dirfd, F_SETSIG, 0);
>  		if (verbose > 0)
>  			xlog_warn("Opened %s", ic->ic_path);
>  	}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Looks correct to me:

Reviewed-by: Jeff Layton <jlayton@redhat.com>