* Regression in current master @ 2011-06-01 7:43 Pavel Shilovsky 2011-06-07 23:01 ` J. Bruce Fields 0 siblings, 1 reply; 3+ messages in thread From: Pavel Shilovsky @ 2011-06-01 7:43 UTC (permalink / raw) To: linux-nfs Hi all! Commit 9274e94db85bac04e170414cb8e0f4be271cde90 (http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9274e94db85bac04e170414cb8e0f4be271cde90) caused the regression when --manage-gids option is enabled: a user doesn't get group list through getgrouplist when auth_unix_gid is called twice. When I remove static attributes from gid_t *groups and int groups_len, it works good. -- Best regards, Pavel Shilovsky. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Regression in current master 2011-06-01 7:43 Regression in current master Pavel Shilovsky @ 2011-06-07 23:01 ` J. Bruce Fields 2011-06-07 23:03 ` J. Bruce Fields 0 siblings, 1 reply; 3+ messages in thread From: J. Bruce Fields @ 2011-06-07 23:01 UTC (permalink / raw) To: Pavel Shilovsky; +Cc: linux-nfs, Sean Finney, Steve Dickson On Wed, Jun 01, 2011 at 11:43:47AM +0400, Pavel Shilovsky wrote: > Commit 9274e94db85bac04e170414cb8e0f4be271cde90 > (http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9274e94db85bac04e170414cb8e0f4be271cde90) > caused the regression when --manage-gids option is enabled: a user > doesn't get group list through getgrouplist when auth_unix_gid is > called twice. When I remove static attributes from gid_t *groups and > int groups_len, it works good. Looking at the patch.... Hm, I can't spot the bug. Sean? (Also, not a correctness issue, but: shouldn't if (rv == -1 && ngroups >= groups_len) { be if (rv == -1 && ngroups > groups_len) { ? And, finally, why do we need the separate groups_len == 0 case at the start at all? The realloc case should be able to handle the initial case as well. ) --b. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Regression in current master 2011-06-07 23:01 ` J. Bruce Fields @ 2011-06-07 23:03 ` J. Bruce Fields 0 siblings, 0 replies; 3+ messages in thread From: J. Bruce Fields @ 2011-06-07 23:03 UTC (permalink / raw) To: Pavel Shilovsky; +Cc: linux-nfs, Sean Finney, Steve Dickson On Tue, Jun 07, 2011 at 07:01:07PM -0400, J. Bruce Fields wrote: > On Wed, Jun 01, 2011 at 11:43:47AM +0400, Pavel Shilovsky wrote: > > Commit 9274e94db85bac04e170414cb8e0f4be271cde90 > > (http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=9274e94db85bac04e170414cb8e0f4be271cde90) > > caused the regression when --manage-gids option is enabled: a user > > doesn't get group list through getgrouplist when auth_unix_gid is > > called twice. When I remove static attributes from gid_t *groups and > > int groups_len, it works good. > > Looking at the patch.... > > Hm, I can't spot the bug. Sean? Whoops, sorry, missed your later message! --b. > > (Also, not a correctness issue, but: shouldn't > > if (rv == -1 && ngroups >= groups_len) { > > be > > if (rv == -1 && ngroups > groups_len) { > > ? > > And, finally, why do we need the separate groups_len == 0 case at the > start at all? The realloc case should be able to handle the initial > case as well. > > ) > > --b. > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-07 23:03 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-06-01 7:43 Regression in current master Pavel Shilovsky 2011-06-07 23:01 ` J. Bruce Fields 2011-06-07 23:03 ` J. Bruce Fields
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).