* [PATCH] svcauth_unix.c: quiet sparse noise
@ 2011-06-21 1:19 H Hartley Sweeten
2011-06-21 22:44 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-06-21 1:19 UTC (permalink / raw)
To: Linux Kernel; +Cc: netdev, linux-nfs, Trond.Myklebust, bfields, neilb, davem
Like svcauth_unix, the symbol svcauth_null is used external from this
file. Declare it as extern to quiet the following sparse noise:
warning: symbol 'svcauth_null' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>
---
diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
index c8e1021..62e49e2 100644
--- a/net/sunrpc/svcauth_unix.c
+++ b/net/sunrpc/svcauth_unix.c
@@ -36,6 +36,7 @@ struct unix_domain {
/* other stuff later */
};
+extern struct auth_ops svcauth_null;
extern struct auth_ops svcauth_unix;
static void svcauth_unix_domain_release(struct auth_domain *dom)
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] svcauth_unix.c: quiet sparse noise
2011-06-21 1:19 [PATCH] svcauth_unix.c: quiet sparse noise H Hartley Sweeten
@ 2011-06-21 22:44 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2011-06-21 22:44 UTC (permalink / raw)
To: H Hartley Sweeten
Cc: Linux Kernel, netdev, linux-nfs, Trond.Myklebust, neilb, davem
On Mon, Jun 20, 2011 at 06:19:12PM -0700, H Hartley Sweeten wrote:
> Like svcauth_unix, the symbol svcauth_null is used external from this
> file. Declare it as extern to quiet the following sparse noise:
>
> warning: symbol 'svcauth_null' was not declared. Should it be static?
Also applying for 3.1.--b.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: Neil Brown <neilb@suse.de>
> Cc: "David S. Miller" <davem@davemloft.net>
>
> ---
>
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index c8e1021..62e49e2 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -36,6 +36,7 @@ struct unix_domain {
> /* other stuff later */
> };
>
> +extern struct auth_ops svcauth_null;
> extern struct auth_ops svcauth_unix;
>
> static void svcauth_unix_domain_release(struct auth_domain *dom)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-21 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-21 1:19 [PATCH] svcauth_unix.c: quiet sparse noise H Hartley Sweeten
2011-06-21 22:44 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).