From: "J. Bruce Fields" <bfields@fieldses.org>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
Trond.Myklebust@netapp.com, neilb@suse.de, davem@davemloft.net
Subject: Re: [PATCH] svcauth_unix.c: quiet sparse noise
Date: Tue, 21 Jun 2011 18:44:30 -0400 [thread overview]
Message-ID: <20110621224430.GC28047@fieldses.org> (raw)
In-Reply-To: <201106201819.12839.hartleys@visionengravers.com>
On Mon, Jun 20, 2011 at 06:19:12PM -0700, H Hartley Sweeten wrote:
> Like svcauth_unix, the symbol svcauth_null is used external from this
> file. Declare it as extern to quiet the following sparse noise:
>
> warning: symbol 'svcauth_null' was not declared. Should it be static?
Also applying for 3.1.--b.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
> Cc: "J. Bruce Fields" <bfields@fieldses.org>
> Cc: Neil Brown <neilb@suse.de>
> Cc: "David S. Miller" <davem@davemloft.net>
>
> ---
>
> diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_unix.c
> index c8e1021..62e49e2 100644
> --- a/net/sunrpc/svcauth_unix.c
> +++ b/net/sunrpc/svcauth_unix.c
> @@ -36,6 +36,7 @@ struct unix_domain {
> /* other stuff later */
> };
>
> +extern struct auth_ops svcauth_null;
> extern struct auth_ops svcauth_unix;
>
> static void svcauth_unix_domain_release(struct auth_domain *dom)
prev parent reply other threads:[~2011-06-21 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-21 1:19 [PATCH] svcauth_unix.c: quiet sparse noise H Hartley Sweeten
2011-06-21 22:44 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621224430.GC28047@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).