linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Cc: linux-nfs@vger.kernel.org, Trond Myklebust <trond@netapp.com>
Subject: Re: autoload rpcsec_gss_krb5
Date: Thu, 23 Jun 2011 16:30:12 -0400	[thread overview]
Message-ID: <20110623203012.GD12357@fieldses.org> (raw)
In-Reply-To: <20110623201117.GB12357@fieldses.org>

On Thu, Jun 23, 2011 at 04:11:17PM -0400, J. Bruce Fields wrote:
> On Thu, Jun 23, 2011 at 10:06:14PM +0200, Tigran Mkrtchyan wrote:
> > I recall a discussion at connectaton 2010, where Peter Staubach from
> > RedHat ( at that time )
> > requested a way to disable pNFS without rebuilding the kernel.
> > 
> > Probably that's why autoload is not implemented.
> 
> Well, autoload *is* implemented, you just have to add an alias command
> to modprobe.conf before it'll work.
> 
> And if we embed the alias in the module instead, it will still be
> possible to disable autloading by adding a "backlist <modulename>" to
> modproble.conf.
> 
> So I don't *think* that's the issue, unless I've missed something.

So can we just do this?  (Untested.)

--b.

commit 8b3065071b5469c428d70052c80f1df3cb398da6
Author: J. Bruce Fields <bfields@redhat.com>
Date:   Thu Jun 23 16:15:39 2011 -0400

    pnfs: simplify pnfs files module autoloading
    
    Embed the necessary alias into the module rather than waiting for
    someone to add it to /etc/modprobe.conf
    
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>

diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index 4269088..eb65f82 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -896,5 +896,7 @@ static void __exit nfs4filelayout_exit(void)
 	pnfs_unregister_layoutdriver(&filelayout_type);
 }
 
+MODULE_ALIAS("nfs-layouttype4-1");
+
 module_init(nfs4filelayout_init);
 module_exit(nfs4filelayout_exit);

  reply	other threads:[~2011-06-23 20:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 21:32 autoload rpcsec_gss_krb5 J. Bruce Fields
2011-06-23 15:59 ` J. Bruce Fields
2011-06-23 20:06   ` Tigran Mkrtchyan
2011-06-23 20:11     ` J. Bruce Fields
2011-06-23 20:30       ` J. Bruce Fields [this message]
2011-06-24  2:22         ` Boaz Harrosh
2011-06-24 14:01           ` J. Bruce Fields
2011-06-24 14:34             ` Trond Myklebust
2011-06-24 14:42               ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110623203012.GD12357@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=tigran.mkrtchyan@desy.de \
    --cc=trond@netapp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).