From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([174.143.236.118]:53266 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553Ab1GLKqx (ORCPT ); Tue, 12 Jul 2011 06:46:53 -0400 Date: Tue, 12 Jul 2011 06:46:52 -0400 To: Masatake YAMATO Cc: linux-nfs@vger.kernel.org, steved@redhat.com Subject: Re: [PATCH] closing fd associated with /proc/fs/nfsd/export_features Message-ID: <20110712104652.GA2162@fieldses.org> References: <20110712.114700.814616059257545652.yamato@redhat.com> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110712.114700.814616059257545652.yamato@redhat.com> From: "J. Bruce Fields" Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Tue, Jul 12, 2011 at 11:47:00AM +0900, Masatake YAMATO wrote: > A fd associated with /proc/fs/nfsd/export_features opened in get_export_features is > not closed. > > > Signed-off-by: Masatake YAMATO Acked-by: J. Bruce Fields > > diff --git a/support/nfs/exports.c b/support/nfs/exports.c > index c250383..819a18a 100644 > --- a/support/nfs/exports.c > +++ b/support/nfs/exports.c > @@ -787,6 +787,7 @@ struct export_features *get_export_features(void) > fd = read(fd, buf, 50); > if (fd == -1) > goto err; > + close(fd); > c = sscanf(buf, "%x %x", &ef.flags, &ef.secinfo_flags); > if (c != 2) > goto err; > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html