From: Jim Rees <rees@umich.edu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: tao.peng@emc.com, linux-nfs@vger.kernel.org, bhalevy@tonian.com,
bergwolf@gmail.com
Subject: Re: [PATCH] NFS41: Drop lseg ref before fallthru to MDS
Date: Mon, 25 Jul 2011 17:35:38 -0400 [thread overview]
Message-ID: <20110725213538.GB7717@merit.edu> (raw)
In-Reply-To: <1311621204.28209.14.camel@lade.trondhjem.org>
Trond Myklebust wrote:
On Wed, 2011-07-20 at 01:52 -0400, tao.peng@emc.com wrote:
> Hi, Trond,
>
> Any comments on this patch? I still get kernel crash when pnfs write is attempted but fails and calls pnfs_ld_write_done(). It seems object layout uses the same code path as well. But I don't find the patch in either your tree or Benny's tree. Are there any concerns?
>
> Thanks,
> Tao
The whole pnfs_ld_write_done thing is bogus and needs to be replaced
with something sane. It is trying to initiate a WRITE RPC call with the
wrong block size, and is calling the MDS rpc_call_done() and
rpc_release() with an uninitialised rpc task pointer.
Ditto for pnfs_ld_read_done.
Benny / Boaz, have you run into this problem with object layout?
next prev parent reply other threads:[~2011-07-25 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 1:30 [PATCH] NFS41: Drop lseg ref before fallthru to MDS Peng Tao
2011-07-09 14:10 ` Benny Halevy
2011-07-20 5:52 ` tao.peng
2011-07-25 19:13 ` Trond Myklebust
2011-07-25 21:35 ` Jim Rees [this message]
2011-07-26 15:37 ` Peng Tao
2011-07-26 15:50 ` Myklebust, Trond
2011-07-26 16:08 ` Jim Rees
2011-07-26 16:14 ` Myklebust, Trond
2011-07-26 16:37 ` Benny Halevy
2011-07-26 17:32 ` Peng Tao
2011-07-26 17:37 ` Myklebust, Trond
2011-07-26 17:57 ` Peng Tao
2011-07-27 10:17 ` tao.peng
2011-07-26 16:34 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110725213538.GB7717@merit.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=bergwolf@gmail.com \
--cc=bhalevy@tonian.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tao.peng@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).