Linux NFS development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: linux-nfs@vger.kernel.org
Subject: nfs_need_sync_write
Date: Wed, 10 Aug 2011 06:21:26 -0400	[thread overview]
Message-ID: <20110810102126.GA3000@infradead.org> (raw)

This helper returns true for the IS_SYNC or O_SYNC conditions which
are already handled in generic code using generic_write_sync, leading
to a double data writeout in both the write and splice_write path.  Even
worse nfs is using vfs_fsync instead of the range variant used by the
generic code, making O_SYNC writes on NFS much heavier than they need to
be.

                 reply	other threads:[~2011-08-10 10:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110810102126.GA3000@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox