From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fieldses.org ([174.143.236.118]:48659 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754213Ab1IHXVT (ORCPT ); Thu, 8 Sep 2011 19:21:19 -0400 Date: Thu, 8 Sep 2011 14:21:49 -0400 To: Chuck Lever Cc: linux-nfs@vger.kernel.org Subject: Re: [PATCH 3/3] NFSD: Add a cache for fs_locations information Message-ID: <20110908182149.GC16740@fieldses.org> References: <20110902162210.32190.5880.stgit@matisse.1015granger.net> <20110902163842.32190.52896.stgit@matisse.1015granger.net> Content-Type: text/plain; charset=us-ascii In-Reply-To: <20110902163842.32190.52896.stgit@matisse.1015granger.net> From: "J. Bruce Fields" Sender: linux-nfs-owner@vger.kernel.org List-ID: MIME-Version: 1.0 On Fri, Sep 02, 2011 at 12:38:42PM -0400, Chuck Lever wrote: > From: Trond Myklebust > > Signed-off-by: Trond Myklebust > [ cel: since this is server-side, use nfsd4_ prefix instead of nfs4_ prefix. ] > [ cel: implement S_ISVTX filter in bfields-normal form ] > Signed-off-by: Chuck Lever OK, and this is all it takes to get entries for these added to the export cache, so we're done? --b. > --- > > fs/nfsd/nfsd.h | 7 +++++++ > fs/nfsd/vfs.c | 16 ++++++++++++++++ > 2 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h > index 7ecfa24..d314812 100644 > --- a/fs/nfsd/nfsd.h > +++ b/fs/nfsd/nfsd.h > @@ -335,6 +335,13 @@ static inline u32 nfsd_suppattrs2(u32 minorversion) > #define NFSD_SUPPATTR_EXCLCREAT_WORD2 \ > NFSD_WRITEABLE_ATTRS_WORD2 > > +extern int nfsd4_is_junction(struct dentry *dentry); > +#else > +static inline int nfsd4_is_junction(struct dentry *dentry) > +{ > + return 0; > +} > + > #endif /* CONFIG_NFSD_V4 */ > > #endif /* LINUX_NFSD_NFSD_H */ > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c > index fd0acca..1f2d5bf 100644 > --- a/fs/nfsd/vfs.c > +++ b/fs/nfsd/vfs.c > @@ -168,6 +168,8 @@ int nfsd_mountpoint(struct dentry *dentry, struct svc_export *exp) > { > if (d_mountpoint(dentry)) > return 1; > + if (nfsd4_is_junction(dentry)) > + return 1; > if (!(exp->ex_flags & NFSEXP_V4ROOT)) > return 0; > return dentry->d_inode != NULL; > @@ -592,6 +594,20 @@ nfsd4_get_nfs4_acl(struct svc_rqst *rqstp, struct dentry *dentry, struct nfs4_ac > return error; > } > > +#define NFSD_XATTR_JUNCTION_PREFIX XATTR_TRUSTED_PREFIX "junction." > +#define NFSD_XATTR_JUNCTION_TYPE NFSD_XATTR_JUNCTION_PREFIX "type" > +int nfsd4_is_junction(struct dentry *dentry) > +{ > + struct inode *inode = dentry->d_inode; > + > + if (inode == NULL) > + return 0; > + if (!(inode->i_mode & S_ISVTX)) > + return 0; > + if (vfs_getxattr(dentry, NFSD_XATTR_JUNCTION_TYPE, NULL, 0) <= 0) > + return 0; > + return 1; > +} > #endif /* defined(CONFIG_NFSD_V4) */ > > #ifdef CONFIG_NFSD_V3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html