From: Jim Rees <rees@umich.edu>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: shouldn't rpc_pipe_upcall message structs be __attribute__((packed)) ?
Date: Fri, 9 Sep 2011 15:56:15 -0400 [thread overview]
Message-ID: <20110909195615.GA21276@merit.edu> (raw)
In-Reply-To: <20110909143605.57d54899@tlielax.poochiereds.net>
Jeff Layton wrote:
The blocklayout upcall is even more scary as the width of the status
field is not explicit:
struct bl_dev_msg {
int status;
uint32_t major, minor;
};
I'll take the blame for that one. I will queue up a fix.
Making the blocklayout upcall struct packed might still be possible since
it's not officially released until 3.1, but I'm terrified of making changes
at this point in the release cycle that aren't actual bug fixes.
next prev parent reply other threads:[~2011-09-09 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-09 18:36 shouldn't rpc_pipe_upcall message structs be __attribute__((packed)) ? Jeff Layton
2011-09-09 19:56 ` Jim Rees [this message]
2011-09-09 21:16 ` Jeff Layton
2011-09-09 22:03 ` Jim Rees
2011-09-09 22:32 ` Trond Myklebust
2011-09-10 0:14 ` Jeff Layton
2011-09-09 20:03 ` J. Bruce Fields
2011-09-09 21:05 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110909195615.GA21276@merit.edu \
--to=rees@umich.edu \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).