From: Jeff Layton <jlayton@redhat.com>
To: Jim Rees <rees@umich.edu>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, peter honeyman <honey@citi.umich.edu>
Subject: Re: [PATCH v7 12/26] pnfsblock: add device operations
Date: Tue, 13 Sep 2011 11:14:41 -0400 [thread overview]
Message-ID: <20110913111441.4b2502b8@corrin.poochiereds.net> (raw)
In-Reply-To: <1312073576-11024-13-git-send-email-rees@umich.edu>
On Sat, 30 Jul 2011 20:52:42 -0400
Jim Rees <rees@umich.edu> wrote:
> Signed-off-by: Jim Rees <rees@umich.edu>
> Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
> Signed-off-by: Benny Halevy <bhalevy@panasas.com>
> Signed-off-by: Benny Halevy <bhalevy@tonian.com>
> [upcall bugfixes]
> Signed-off-by: Peng Tao <peng_tao@emc.com>
> ---
> fs/nfs/blocklayout/Makefile | 2 +-
> fs/nfs/blocklayout/blocklayout.c | 42 ++++++++
> fs/nfs/blocklayout/blocklayout.h | 40 +++++++
> fs/nfs/blocklayout/blocklayoutdev.c | 191 +++++++++++++++++++++++++++++++++++
> fs/nfs/client.c | 2 +-
> include/linux/nfs.h | 2 +
> 6 files changed, 277 insertions(+), 2 deletions(-)
> create mode 100644 fs/nfs/blocklayout/blocklayoutdev.c
>
[...]
> +static const struct rpc_pipe_ops bl_upcall_ops = {
> + .upcall = bl_pipe_upcall,
> + .downcall = bl_pipe_downcall,
> + .destroy_msg = bl_pipe_destroy_msg,
> +};
> +
> static int __init nfs4blocklayout_init(void)
> {
> + struct vfsmount *mnt;
> + struct path path;
> int ret;
>
> dprintk("%s: NFSv4 Block Layout Driver Registering...\n", __func__);
>
> ret = pnfs_register_layoutdriver(&blocklayout_type);
> + if (ret)
> + goto out;
> +
> + init_waitqueue_head(&bl_wq);
> +
> + mnt = rpc_get_mount();
> + if (IS_ERR(mnt)) {
> + ret = PTR_ERR(mnt);
> + goto out_remove;
> + }
> +
Hmm...sorry for the late review on this, but I was just looking over
this code as an example for some other stuff I'm working on...
I notice that the above code does a rpc_get_mount to get a reference to
the rpc_pipefs mount, but I don't see where that reference is ever put.
> + ret = vfs_path_lookup(mnt->mnt_root,
> + mnt,
> + NFS_PIPE_DIRNAME, 0, &path);
> + if (ret)
> + goto out_remove;
> +
> + bl_device_pipe = rpc_mkpipe(path.dentry, "blocklayout", NULL,
> + &bl_upcall_ops, 0);
> + if (IS_ERR(bl_device_pipe)) {
> + ret = PTR_ERR(bl_device_pipe);
> + goto out_remove;
> + }
> +out:
> + return ret;
> +
> +out_remove:
> + pnfs_unregister_layoutdriver(&blocklayout_type);
> return ret;
> }
>
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2011-09-13 15:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-31 0:52 [PATCH v7 00/26] add block layout driver to pnfs client Jim Rees
2011-07-31 0:52 ` [PATCH v7 01/26] pnfs: save layoutcommit lwb at layout header Jim Rees
2011-07-31 0:52 ` [PATCH v7 02/26] pnfs: save layoutcommit cred at layout header init Jim Rees
2011-07-31 0:52 ` [PATCH v7 03/26] pnfs: let layoutcommit handle a list of lseg Jim Rees
2011-07-31 0:52 ` [PATCH v7 04/26] pnfs: use lwb as layoutcommit length Jim Rees
2011-07-31 0:52 ` [PATCH v7 05/26] pnfs: GETDEVICELIST Jim Rees
2011-07-31 0:52 ` [PATCH v7 06/26] pnfs: add set-clear layoutdriver interface Jim Rees
2011-07-31 0:52 ` [PATCH v7 07/26] pnfs: ask for layout_blksize and save it in nfs_server Jim Rees
2011-07-31 0:52 ` [PATCH v7 08/26] pnfs: cleanup_layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 09/26] pnfsblock: add blocklayout Kconfig option, Makefile, and stubs Jim Rees
2011-07-31 0:52 ` [PATCH v7 10/26] pnfsblock: use pageio_ops api Jim Rees
2011-07-31 0:52 ` [PATCH v7 11/26] pnfsblock: basic extent code Jim Rees
2011-07-31 0:52 ` [PATCH v7 12/26] pnfsblock: add device operations Jim Rees
2011-09-13 15:14 ` Jeff Layton [this message]
2011-09-13 15:16 ` Jeff Layton
2011-09-13 15:49 ` Peng Tao
2011-07-31 0:52 ` [PATCH v7 13/26] pnfsblock: remove " Jim Rees
2011-07-31 0:52 ` [PATCH v7 14/26] pnfsblock: lseg alloc and free Jim Rees
2011-07-31 0:52 ` [PATCH v7 15/26] pnfsblock: merge extents Jim Rees
2011-07-31 0:52 ` [PATCH v7 16/26] pnfsblock: call and parse getdevicelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 17/26] pnfsblock: xdr decode pnfs_block_layout4 Jim Rees
2011-07-31 0:52 ` [PATCH v7 18/26] pnfsblock: bl_find_get_extent Jim Rees
2011-07-31 0:52 ` [PATCH v7 19/26] pnfsblock: add extent manipulation functions Jim Rees
2011-07-31 0:52 ` [PATCH v7 20/26] pnfsblock: merge rw extents Jim Rees
2011-07-31 0:52 ` [PATCH v7 21/26] pnfsblock: encode_layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 22/26] pnfsblock: cleanup_layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 23/26] pnfsblock: bl_read_pagelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 24/26] pnfsblock: bl_write_pagelist Jim Rees
2011-07-31 0:52 ` [PATCH v7 25/26] pnfsblock: note written INVAL areas for layoutcommit Jim Rees
2011-07-31 0:52 ` [PATCH v7 26/26] pnfsblock: write_pagelist handle zero invalid extents Jim Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110913111441.4b2502b8@corrin.poochiereds.net \
--to=jlayton@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=honey@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=rees@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).