From: Stanislav Kinsbursky <skinsbursky@parallels.com>
To: Trond.Myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org, xemul@parallels.com, neilb@suse.de,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bfields@fieldses.org, davem@davemloft.net
Subject: [PATCH v4 2/8] SUNRPC: use rpcbind reference counting helpers
Date: Tue, 20 Sep 2011 14:13:49 +0400 [thread overview]
Message-ID: <20110920101349.9861.42381.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20110920101031.9861.18444.stgit@localhost6.localdomain6>
All is simple: we just increase users counter if rpcbind clients has been
created already. Otherwise we create them and set users counter to 1.
Signed-off-by: Stanislav Kinsbursky <skinsbursky@parallels.com>
---
net/sunrpc/rpcb_clnt.c | 12 ++++--------
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
index 8724780..83634e0 100644
--- a/net/sunrpc/rpcb_clnt.c
+++ b/net/sunrpc/rpcb_clnt.c
@@ -255,9 +255,7 @@ static int rpcb_create_local_unix(void)
clnt4 = NULL;
}
- /* Protected by rpcb_create_local_mutex */
- rpcb_local_clnt = clnt;
- rpcb_local_clnt4 = clnt4;
+ rpcb_set_local(clnt, clnt4);
out:
return result;
@@ -309,9 +307,7 @@ static int rpcb_create_local_net(void)
clnt4 = NULL;
}
- /* Protected by rpcb_create_local_mutex */
- rpcb_local_clnt = clnt;
- rpcb_local_clnt4 = clnt4;
+ rpcb_set_local(clnt, clnt4);
out:
return result;
@@ -326,11 +322,11 @@ static int rpcb_create_local(void)
static DEFINE_MUTEX(rpcb_create_local_mutex);
int result = 0;
- if (rpcb_local_clnt)
+ if (rpcb_get_local())
return result;
mutex_lock(&rpcb_create_local_mutex);
- if (rpcb_local_clnt)
+ if (rpcb_get_local())
goto out;
if (rpcb_create_local_unix() != 0)
next prev parent reply other threads:[~2011-09-20 10:14 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 10:13 [PATCH v4 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically Stanislav Kinsbursky
2011-09-20 10:13 ` [PATCH v4 1/8] SUNRPC: introduce helpers for reference counted rpcbind clients Stanislav Kinsbursky
2011-09-20 13:05 ` Bryan Schumaker
2011-09-20 13:15 ` Myklebust, Trond
2011-09-20 13:34 ` Stanislav Kinsbursky
2011-09-20 14:14 ` Myklebust, Trond
2011-09-20 14:35 ` Stanislav Kinsbursky
2011-09-20 14:38 ` Myklebust, Trond
2011-09-20 15:03 ` Stanislav Kinsbursky
2011-09-20 16:20 ` Stanislav Kinsbursky
2011-09-20 17:13 ` Myklebust, Trond
2011-09-20 17:26 ` Stanislav Kinsbursky
2011-09-20 13:49 ` [PATCH v5 " Stanislav Kinsbursky
2011-09-20 14:24 ` Jeff Layton
2011-09-20 14:41 ` Myklebust, Trond
2011-09-20 15:58 ` Stanislav Kinsbursky
2011-09-20 14:43 ` Stanislav Kinsbursky
2011-09-20 14:58 ` Bryan Schumaker
2011-09-20 15:38 ` Stanislav Kinsbursky
2011-09-20 16:06 ` Bryan Schumaker
2011-09-20 15:11 ` Jeff Layton
2011-09-20 16:20 ` Stanislav Kinsbursky
2011-09-21 9:07 ` [PATCH v6 " Stanislav Kinsbursky
2011-09-23 14:41 ` Stanislav Kinsbursky
2011-09-23 17:26 ` Myklebust, Trond
2011-09-20 10:13 ` Stanislav Kinsbursky [this message]
2011-09-20 10:13 ` [PATCH v4 3/8] SUNRPC: introduce svc helpers for prepairing rpcbind infrastructure Stanislav Kinsbursky
2011-09-20 10:14 ` [PATCH v4 4/8] SUNRPC: setup rpcbind clients if service requires it Stanislav Kinsbursky
2011-09-20 11:22 ` Jeff Layton
2011-09-20 10:14 ` [PATCH v4 5/8] SUNRPC: cleanup service destruction Stanislav Kinsbursky
2011-09-20 10:14 ` [PATCH v4 6/8] NFSd: call svc rpcbind cleanup explicitly Stanislav Kinsbursky
2011-09-20 10:14 ` [PATCH v4 7/8] SUNRPC: remove rpcbind clients creation during service registering Stanislav Kinsbursky
2011-09-20 10:14 ` [PATCH v4 8/8] SUNRPC: remove rpcbind clients destruction on module cleanup Stanislav Kinsbursky
2011-09-20 11:24 ` [PATCH v4 0/8] SUNRPC: make rpcbind clients allocated and destroyed dynamically Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110920101349.9861.42381.stgit@localhost6.localdomain6 \
--to=skinsbursky@parallels.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).