From: Chuck Lever <chuck.lever@oracle.com>
To: linux-nfs@vger.kernel.org
Cc: bjschuma@netapp.com, andros@netapp.com
Subject: [PATCH 3/3] NFS: Remove no-op less-than-zero checks on unsigned variables.
Date: Mon, 26 Sep 2011 11:30:13 -0400 [thread overview]
Message-ID: <20110926153013.8595.41253.stgit@degas.1015granger.net> (raw)
In-Reply-To: <20110926152657.8595.6375.stgit@degas.1015granger.net>
Introduced by commit 16b374ca "NFSv4.1: pnfs: filelayout: add driver's
LAYOUTGET and GETDEVICEINFO infrastructure" (October 20, 2010).
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfs/nfs4filelayout.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c
index e8915d4..bbc5a21 100644
--- a/fs/nfs/nfs4filelayout.c
+++ b/fs/nfs/nfs4filelayout.c
@@ -468,9 +468,8 @@ filelayout_check_layout(struct pnfs_layout_hdr *lo,
fl->dsaddr = dsaddr;
- if (fl->first_stripe_index < 0 ||
- fl->first_stripe_index >= dsaddr->stripe_count) {
- dprintk("%s Bad first_stripe_index %d\n",
+ if (fl->first_stripe_index >= dsaddr->stripe_count) {
+ dprintk("%s Bad first_stripe_index %u\n",
__func__, fl->first_stripe_index);
goto out_put;
}
@@ -571,7 +570,7 @@ filelayout_decode_layout(struct pnfs_layout_hdr *flo,
/* Note that a zero value for num_fh is legal for STRIPE_SPARSE.
* Futher checking is done in filelayout_check_layout */
- if (fl->num_fh < 0 || fl->num_fh >
+ if (fl->num_fh >
max(NFS4_PNFS_MAX_STRIPE_CNT, NFS4_PNFS_MAX_MULTI_CNT))
goto out_err;
next prev parent reply other threads:[~2011-09-26 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 15:29 [PATCH 0/3] Three tiny clean-ups for 3.2 Chuck Lever
2011-09-26 15:29 ` [PATCH 1/3] NFS: Fix documenting comment for nfs_create_request() Chuck Lever
2011-09-26 15:30 ` [PATCH 2/3] NFS: Clean up nfs4_xdr_dec_secinfo() Chuck Lever
2011-09-26 15:30 ` Chuck Lever [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-25 16:17 [PATCH 0/3] Three tiny clean-ups for 3.2 (repost) Chuck Lever
2011-10-25 16:18 ` [PATCH 3/3] NFS: Remove no-op less-than-zero checks on unsigned variables Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110926153013.8595.41253.stgit@degas.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=andros@netapp.com \
--cc=bjschuma@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).