From: Greg KH <gregkh@suse.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ian Kent <raven@themaw.net>,
Trond Myklebust <Trond.Myklebust@netapp.com>,
Jeff Layton <jlayton@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
David Howells <dhowells@redhat.com>,
viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org,
leonardo.lists@gmail.com
Subject: Re: [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc.
Date: Tue, 27 Sep 2011 10:38:22 -0700 [thread overview]
Message-ID: <20110927173822.GC24197@suse.de> (raw)
In-Reply-To: <CA+55aFwf8z+pi3okC2GmuYYKTN3hz+j5Y4XX4B=VrOP+YG0Qpw@mail.gmail.com>
On Tue, Sep 27, 2011 at 08:22:24AM -0700, Linus Torvalds wrote:
> On Mon, Sep 26, 2011 at 9:51 PM, Ian Kent <raven@themaw.net> wrote:
> >
> > Yes, I also thought that AT_NO_AUTOMOUNT would need to be removed and
> > AT_AUTOMOUNT added as part of the change. But that can be done as a
> > follow up.
>
> In fact, since reasonably automounting will always be an issue only
> for directories (yeah, in theory you could extend it to regular files,
> but why would you?) it's probably not even worth adding AT_AUTOMOUNT
> at all - you can do the same thing by just adding a '/' at the end of
> the filename instead, and suddenly it works for *all* the stat()
> family system calls, not just the odd statat() ones that almost nobody
> uses.
>
> So it would be easy to add the AT_AUTOMOUNT flag, but whoever argues
> for it would have to be pretty convincing as to why it would be worth
> it.
>
> I committed the patch I sent out with your and Trond's acks.
Does any of this make any sense for the 3.0-stable tree as well?
greg k-h
next prev parent reply other threads:[~2011-09-27 17:44 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 13:45 [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc David Howells
2011-09-22 14:33 ` Miklos Szeredi
2011-09-22 16:04 ` Ian Kent
2011-09-22 16:30 ` Linus Torvalds
2011-09-22 16:45 ` Ian Kent
2011-09-22 17:35 ` Jeff Layton
2011-09-22 18:44 ` Jeff Layton
2011-09-22 19:20 ` Trond Myklebust
2011-09-22 22:57 ` Linus Torvalds
2011-09-23 0:56 ` Myklebust, Trond
2011-09-23 1:04 ` Linus Torvalds
2011-09-23 1:21 ` Trond Myklebust
2011-09-23 7:25 ` Miklos Szeredi
2011-09-23 10:57 ` Ian Kent
2011-09-23 3:15 ` Ian Kent
2011-09-23 10:33 ` David Howells
2011-09-23 14:34 ` Trond Myklebust
2011-09-23 14:46 ` Linus Torvalds
2011-09-23 15:01 ` Trond Myklebust
2011-09-23 15:15 ` Linus Torvalds
2011-09-23 15:41 ` Ian Kent
2011-09-23 16:19 ` Miklos Szeredi
2011-09-23 16:21 ` Linus Torvalds
2011-09-23 16:26 ` Linus Torvalds
[not found] ` <13920.1316796007@redhat.com! >
2011-09-23 16:54 ` David Howells
2011-09-23 17:18 ` Linus Torvalds
2011-09-23 16:40 ` David Howells
2011-09-23 16:47 ` Linus Torvalds
2011-09-23 15:18 ` David Howells
2011-09-23 16:10 ` Miklos Szeredi
2011-09-24 1:30 ` Ian Kent
2011-09-24 1:44 ` Linus Torvalds
2011-09-24 2:31 ` Ian Kent
2011-09-24 11:36 ` Jeff Layton
2011-09-24 15:56 ` Linus Torvalds
2011-09-26 5:11 ` Ian Kent
2011-09-26 20:48 ` Linus Torvalds
2011-09-26 21:13 ` Trond Myklebust
2011-09-26 21:24 ` Linus Torvalds
2011-09-26 21:31 ` Trond Myklebust
2011-09-26 22:24 ` Linus Torvalds
2011-09-26 22:33 ` Trond Myklebust
2011-09-26 22:56 ` Linus Torvalds
2011-09-26 23:09 ` Trond Myklebust
2011-09-26 23:26 ` Linus Torvalds
2011-09-27 0:59 ` Trond Myklebust
2011-09-27 1:18 ` Linus Torvalds
2011-09-27 4:24 ` Ian Kent
2011-09-27 3:57 ` Linus Torvalds
2011-09-27 4:16 ` Ian Kent
2011-09-27 4:35 ` Linus Torvalds
2011-09-27 4:51 ` Ian Kent
2011-09-27 14:32 ` Linus Torvalds
2011-09-27 15:11 ` Myklebust, Trond
2011-09-29 9:32 ` Ian Kent
2011-09-27 15:22 ` Linus Torvalds
2011-09-27 17:38 ` Greg KH [this message]
2011-09-27 17:51 ` Linus Torvalds
2011-09-27 18:00 ` Greg KH
2011-09-27 20:18 ` Miklos Szeredi
2011-09-27 22:38 ` Greg KH
2011-09-27 13:34 ` [PATCH 1/2] VFS: Fix the remaining automounter semantics regressions Trond Myklebust
2011-09-27 13:34 ` [PATCH 2/2] VFS: Document automounter semantics Trond Myklebust
2011-09-23 15:23 ` [PATCH] VFS: Suppress automount on [l]stat, [l]getxattr, etc David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927173822.GC24197@suse.de \
--to=gregkh@suse.de \
--cc=Trond.Myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=jlayton@redhat.com \
--cc=leonardo.lists@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).