From: Jeff Layton <jlayton@redhat.com>
To: Steve French <smfrench@gmail.com>
Cc: trond.myklebust@netapp.com, pavel@ucw.cz, rjw@sisk.pl,
linux-pm@lists.linux-foundation.org, linux-cifs@vger.kernel.org,
linux-nfs@vger.kernel.org, john@calva.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] cifs, freezer: add wait_event_freezekillable and have cifs use it
Date: Thu, 29 Sep 2011 13:29:00 -0400 [thread overview]
Message-ID: <20110929132900.47a7aa40@barsoom.rdu.redhat.com> (raw)
In-Reply-To: <CAH2r5ms8pg7VW7JMa_eCUomEC1cfiM+rG_JZ6F7cHB=MtZwF0A@mail.gmail.com>
On Thu, 29 Sep 2011 11:39:53 -0500
Steve French <smfrench@gmail.com> wrote:
> On Thu, Sep 29, 2011 at 5:41 AM, Jeff Layton <jlayton@redhat.com> wrote:
> > On Wed, 28 Sep 2011 23:28:02 -0500
> > Steve French <smfrench@gmail.com> wrote:
> >
> >> The general idea of the patch seems like a good idea to
> >> me. Assuming testing feedback was good from the problem
> >> reporters, what tree would you want it merged from?
> >>
> >
> > There's the rub -- this requires a number of changes in different
> > areas. What I really need at this point is a verdict on patch #1. If
> > that looks OK, then that should probably go in via the one of the
> > linux-pm trees. Then patch #2 can probably go in via your tree and 3
> > and 4 can go in via Trond's.
>
> Yes - makes sense, but wonder about ways to test the various
> suspend/hibernate cases to make sure they work.
>
I think this set is unlikely to hurt anything (assuming of course that
waking up TASK_KILLABLE tasks on suspend events is OK). It's possible
that there are other places that need to be patched in the same way,
but this seems to cover the main pain points that people have reported.
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2011-09-29 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 11:52 [PATCH 0/4] allow freezing of tasks with netfs calls in flight Jeff Layton
2011-09-28 11:52 ` [PATCH 1/4] freezer: make fake_signal_wake_up wake TASK_KILLABLE tasks too Jeff Layton
2011-10-11 6:18 ` Pavel Machek
2011-10-11 10:10 ` Jeff Layton
2011-10-11 19:14 ` Rafael J. Wysocki
2011-10-26 19:55 ` Jeff Layton
2011-10-27 20:21 ` Rafael J. Wysocki
2011-10-27 20:22 ` [linux-pm] " Rafael J. Wysocki
2011-10-27 20:26 ` Steve French
2011-09-28 11:52 ` [PATCH 2/4] cifs, freezer: add wait_event_freezekillable and have cifs use it Jeff Layton
2011-09-29 4:28 ` Steve French
2011-09-29 10:41 ` Jeff Layton
2011-09-29 16:39 ` Steve French
2011-09-29 17:29 ` Jeff Layton [this message]
2011-09-28 11:52 ` [PATCH 3/4] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-10-11 6:19 ` Pavel Machek
2011-10-11 10:12 ` Jeff Layton
2011-10-11 12:52 ` Myklebust, Trond
2011-10-11 13:14 ` Jeff Layton
2011-09-28 11:52 ` [PATCH 4/4] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
2011-10-19 15:18 ` [PATCH 4/4] nfs: make TASK_KILLABLE sleeps attempt to freeze (try #2) Jeff Layton
2011-10-11 6:18 ` [PATCH 0/4] allow freezing of tasks with netfs calls in flight Pavel Machek
2011-10-11 10:05 ` Jeff Layton
2011-10-11 19:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110929132900.47a7aa40@barsoom.rdu.redhat.com \
--to=jlayton@redhat.com \
--cc=john@calva.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=smfrench@gmail.com \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).