* Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
@ 2011-10-20 12:22 Benny Halevy
2011-10-20 12:26 ` J. Bruce Fields
0 siblings, 1 reply; 5+ messages in thread
From: Benny Halevy @ 2011-10-20 12:22 UTC (permalink / raw)
To: J. Bruce Fields, Benny Halevy; +Cc: J. Bruce Fields, linux-nfs
VGhlIG90aGVyIHBhdGNoIHdhcyBmb3IgdGhlIGRlbnkgYml0cyB0aGlzIGlzIGZvciB0aGUgd2Fu
dCBtYXNrLi4uDQpTaW1pbGFyIGJ1ZywgZGlmZmVyZW50IHBsYWNlIDopDQoNCkJlbm55DQotLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0tDQpGcm9tOiBKLiBCcnVjZSBGaWVsZHMNClRvOiBCZW5u
eSBIYWxldnkNCkNjOiBKLiBCcnVjZSBGaWVsZHMNCkNjOiBsaW51eC1uZnNAdmdlci5rZXJuZWwu
b3JnDQpDYzogQmVubnkgSGFsZXZ5DQpTdWJqZWN0OiBSZTogW1BBVENIIDYvN10gbmZzZDQ6IHR5
cG8gbG9naWNhbCB2cyBiaXR3aXNlIG5lZ2F0ZSBmb3Igd2FudF9tYXNrDQpTZW50OiBPY3QgMjAs
IDIwMTEgMDQ6NTMNCg0KWWVwLCBiYWQgbWlzdGFrZSBvbiBteSBwYXJ0LS1idXQgc29tZW9uZSBl
bHNlIGFscmVhZHkgY2F1Z2h0IHRoaXMsIGFuZA0KaXQncyBhbHJlYWR5IGNvbW1pdHRlZCB0byBt
eSAzLjIgYnJhbmNoLi0tYi4NCg0KT24gV2VkLCBPY3QgMTksIDIwMTEgYXQgMDc6MTM6MjlQTSAt
MDcwMCwgQmVubnkgSGFsZXZ5IHdyb3RlOg0KPiBGcm9tOiBCZW5ueSBIYWxldnkgPGJoYWxldnlA
dG9uaWFuLmNvbT4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEJlbm55IEhhbGV2eSA8YmhhbGV2eUB0
b25pYW4uY29tPg0KPiAtLS0NCj4gIGZzL25mc2QvbmZzNHhkci5jIHwgICAgMiArLQ0KPiAgMSBm
aWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZm
IC0tZ2l0IGEvZnMvbmZzZC9uZnM0eGRyLmMgYi9mcy9uZnNkL25mczR4ZHIuYw0KPiBpbmRleCAx
YTQxOWMwLi4xYTVjYjdlIDEwMDY0NA0KPiAtLS0gYS9mcy9uZnNkL25mczR4ZHIuYw0KPiArKysg
Yi9mcy9uZnNkL25mczR4ZHIuYw0KPiBAQCAtNjcxLDcgKzY3MSw3IEBAIHN0YXRpYyBfX2JlMzIg
bmZzZDRfZGVjb2RlX3NoYXJlX2FjY2VzcyhzdHJ1Y3QgbmZzZDRfY29tcG91bmRhcmdzICphcmdw
LCB1MzIgKngpDQo+ICAJZGVmYXVsdDoNCj4gIAkJcmV0dXJuIG5mc2Vycl9iYWRfeGRyOw0KPiAg
CX0NCj4gLQl3ICY9ICFORlM0X1NIQVJFX1dBTlRfTUFTSzsNCj4gKwl3ICY9IH5ORlM0X1NIQVJF
X1dBTlRfTUFTSzsNCj4gIAlpZiAoIXcpDQo+ICAJCXJldHVybiBuZnNfb2s7DQo+ICAJc3dpdGNo
ICh3KSB7DQo+IC0tIA0KPiAxLjcuNg0KPiANCg0K
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
2011-10-20 12:22 [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask Benny Halevy
@ 2011-10-20 12:26 ` J. Bruce Fields
2011-10-20 16:14 ` Boaz Harrosh
0 siblings, 1 reply; 5+ messages in thread
From: J. Bruce Fields @ 2011-10-20 12:26 UTC (permalink / raw)
To: Benny Halevy; +Cc: J. Bruce Fields, Benny Halevy, linux-nfs
On Thu, Oct 20, 2011 at 12:22:41PM +0000, Benny Halevy wrote:
> The other patch was for the deny bits this is for the want mask...
> Similar bug, different place :)
Oog, sorry! OK, applying.
(And in fact I made the same ! for ~ mistake in one other place in the
last week that got caught by regression testing before I posted it. I
need to teach my editor to highlight !'s in blinking red, or
something....)
--b.
>
> Benny
> ------Original Message------
> From: J. Bruce Fields
> To: Benny Halevy
> Cc: J. Bruce Fields
> Cc: linux-nfs@vger.kernel.org
> Cc: Benny Halevy
> Subject: Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
> Sent: Oct 20, 2011 04:53
>
> Yep, bad mistake on my part--but someone else already caught this, and
> it's already committed to my 3.2 branch.--b.
>
> On Wed, Oct 19, 2011 at 07:13:29PM -0700, Benny Halevy wrote:
> > From: Benny Halevy <bhalevy@tonian.com>
> >
> > Signed-off-by: Benny Halevy <bhalevy@tonian.com>
> > ---
> > fs/nfsd/nfs4xdr.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> > index 1a419c0..1a5cb7e 100644
> > --- a/fs/nfsd/nfs4xdr.c
> > +++ b/fs/nfsd/nfs4xdr.c
> > @@ -671,7 +671,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
> > default:
> > return nfserr_bad_xdr;
> > }
> > - w &= !NFS4_SHARE_WANT_MASK;
> > + w &= ~NFS4_SHARE_WANT_MASK;
> > if (!w)
> > return nfs_ok;
> > switch (w) {
> > --
> > 1.7.6
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
2011-10-20 12:26 ` J. Bruce Fields
@ 2011-10-20 16:14 ` Boaz Harrosh
0 siblings, 0 replies; 5+ messages in thread
From: Boaz Harrosh @ 2011-10-20 16:14 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: Benny Halevy, J. Bruce Fields, Benny Halevy, linux-nfs
On 10/20/2011 05:26 AM, J. Bruce Fields wrote:
> On Thu, Oct 20, 2011 at 12:22:41PM +0000, Benny Halevy wrote:
>> The other patch was for the deny bits this is for the want mask...
>> Similar bug, different place :)
>
> Oog, sorry! OK, applying.
>
> (And in fact I made the same ! for ~ mistake in one other place in the
> last week that got caught by regression testing before I posted it. I
> need to teach my editor to highlight !'s in blinking red, or
> something....)
>
That's easy. Imagine your 8th grade teacher's face on the "!" key. The
habit will go away fast.
> --b.
>
Boaz
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/7] Bakeathon server fixes
@ 2011-10-20 2:10 Benny Halevy
2011-10-20 2:13 ` [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask Benny Halevy
0 siblings, 1 reply; 5+ messages in thread
From: Benny Halevy @ 2011-10-20 2:10 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: NFS list
Here's the list of patches I tested here in the Bakeathon.
They pass the Connectathon tests over nfsv4.1 (no pnfs)
against the linux client, but VMware reports a bug with
OPEN with share_access==0x401 (1025)
NFS4_SHARE_WANT_NO_DELEG | NFS4_SHARE_ACCESS_READ
return NFS4ERR_GRACE for some reason.
I haven't been able to track that down yet.
[PATCH 1/7] nfsd4: implement new 4.1 open reclaim types
[PATCH 2/7] nfsd41: use SEQ4_STATUS_BACKCHANNEL_FAULT when
[PATCH 3/7] nfsd4: seq->status_flags may be used unitialized
[PATCH 4/7] nfsd4: allow NFS4_SHARE_SIGNAL_DELEG_WHEN_RESRC_AVAIL |
[PATCH 5/7] nfsd4: implement NFS4_SHARE_WANT_NO_DELEG,
[PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
[PATCH 7/7] nfsd4: share_access_to_flags should consider only nfs4.x
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
2011-10-20 2:10 [PATCH 0/7] Bakeathon server fixes Benny Halevy
@ 2011-10-20 2:13 ` Benny Halevy
2011-10-20 11:53 ` J. Bruce Fields
0 siblings, 1 reply; 5+ messages in thread
From: Benny Halevy @ 2011-10-20 2:13 UTC (permalink / raw)
To: J. Bruce Fields; +Cc: linux-nfs, Benny Halevy
From: Benny Halevy <bhalevy@tonian.com>
Signed-off-by: Benny Halevy <bhalevy@tonian.com>
---
fs/nfsd/nfs4xdr.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 1a419c0..1a5cb7e 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -671,7 +671,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
default:
return nfserr_bad_xdr;
}
- w &= !NFS4_SHARE_WANT_MASK;
+ w &= ~NFS4_SHARE_WANT_MASK;
if (!w)
return nfs_ok;
switch (w) {
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask
2011-10-20 2:13 ` [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask Benny Halevy
@ 2011-10-20 11:53 ` J. Bruce Fields
0 siblings, 0 replies; 5+ messages in thread
From: J. Bruce Fields @ 2011-10-20 11:53 UTC (permalink / raw)
To: Benny Halevy; +Cc: J. Bruce Fields, linux-nfs, Benny Halevy
Yep, bad mistake on my part--but someone else already caught this, and
it's already committed to my 3.2 branch.--b.
On Wed, Oct 19, 2011 at 07:13:29PM -0700, Benny Halevy wrote:
> From: Benny Halevy <bhalevy@tonian.com>
>
> Signed-off-by: Benny Halevy <bhalevy@tonian.com>
> ---
> fs/nfsd/nfs4xdr.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index 1a419c0..1a5cb7e 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -671,7 +671,7 @@ static __be32 nfsd4_decode_share_access(struct nfsd4_compoundargs *argp, u32 *x)
> default:
> return nfserr_bad_xdr;
> }
> - w &= !NFS4_SHARE_WANT_MASK;
> + w &= ~NFS4_SHARE_WANT_MASK;
> if (!w)
> return nfs_ok;
> switch (w) {
> --
> 1.7.6
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-20 16:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-20 12:22 [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask Benny Halevy
2011-10-20 12:26 ` J. Bruce Fields
2011-10-20 16:14 ` Boaz Harrosh
-- strict thread matches above, loose matches on Subject: below --
2011-10-20 2:10 [PATCH 0/7] Bakeathon server fixes Benny Halevy
2011-10-20 2:13 ` [PATCH 6/7] nfsd4: typo logical vs bitwise negate for want_mask Benny Halevy
2011-10-20 11:53 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).