linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH] Silence compiler warning
Date: Mon, 31 Oct 2011 21:37:20 -0400	[thread overview]
Message-ID: <20111101013720.GA4237@umich.edu> (raw)

I think this is still needed, isn't it?  I haven't tried compiling
nfs-for-next but I don't see a fix for it in there.

From: Jim Rees <rees@umich.edu>
Date: Sun, 16 Oct 2011 20:06:52 -0400
Subject: [PATCH] Silence compiler warning

fs/nfs/callback_proc.c: In function ‘do_callback_layoutrecall’:
fs/nfs/callback_proc.c:115:26: warning: ‘lo’ may be used uninitialized in this function

No functional change. If no layout is found, we'll return before  using
"lo".

Signed-off-by: Jim Rees <rees@umich.edu>
---
 fs/nfs/callback_proc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
index 43926ad..f384eb1 100644
--- a/fs/nfs/callback_proc.c
+++ b/fs/nfs/callback_proc.c
@@ -112,8 +112,8 @@ static u32 initiate_file_draining(struct nfs_client *clp,
 				  struct cb_layoutrecallargs *args)
 {
 	struct nfs_server *server;
-	struct pnfs_layout_hdr *lo;
-	struct inode *ino;
+	struct pnfs_layout_hdr *lo = NULL;
+	struct inode *ino = NULL;
 	bool found = false;
 	u32 rv = NFS4ERR_NOMATCHING_LAYOUT;
 	LIST_HEAD(free_me_list);
-- 
1.7.4.1

             reply	other threads:[~2011-11-01  1:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01  1:37 Jim Rees [this message]
2011-11-01  2:30 ` [PATCH] Silence compiler warning Trond Myklebust
2011-11-01  2:42   ` Jim Rees
2011-11-01  2:56     ` Trond Myklebust
2011-11-01  3:01       ` Jim Rees
  -- strict thread matches above, loose matches on Subject: below --
2011-10-18 13:07 Benny Halevy
2011-10-17  0:06 Jim Rees
2011-10-17  1:57 ` Benny Halevy
2011-10-17  2:36   ` Jim Rees
2011-10-18  9:50 ` Stanislav Kinsbursky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111101013720.GA4237@umich.edu \
    --to=rees@umich.edu \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).