From: Tejun Heo <tj@kernel.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Jeff Layton <jlayton@redhat.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Steve French <sfrench@samba.org>,
linux-kernel@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>,
linux-pm@vger.kernel.org, linux-cifs@vger.kernel.org,
"J. Bruce Fields" <bfields@fieldses.org>,
Neil Brown <neilb@suse.de>,
linux-nfs@vger.kernel.org
Subject: Re: [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too"
Date: Tue, 1 Nov 2011 09:55:35 -0700 [thread overview]
Message-ID: <20111101165535.GU18855@google.com> (raw)
In-Reply-To: <1320166171.5019.1.camel@lade.trondhjem.org>
Hello,
On Tue, Nov 01, 2011 at 12:49:31PM -0400, Trond Myklebust wrote:
> > #define wait_event_freezekillable(wq, condition) \
> > do { \
> > DEFINE_WAIT(__wait); \
> > for (;;) { \
> > prepare_to_wait(&wq, &__wait, TASK_INTERRUPTIBLE); \
> > if (condition || fatal_signal_pending(current)) \
> > break; \
> > schedule(); \
> > try_to_freeze(); \
> > } \
> > finish_wait(&wq, &__wait); \
> > } while (0)
>
> Err... Won't this end up busy-waiting if a non-fatal signal is received?
Ah... right, forgot about signal_pending_state() special case in
schedule(). Any better ideas, anyone?
--
tejun
next prev parent reply other threads:[~2011-11-01 16:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111031221743.GA18855@google.com>
[not found] ` <201111010024.16659.rjw@sisk.pl>
[not found] ` <20111031233059.GI18855@google.com>
[not found] ` <20111101005505.GO18855@google.com>
2011-11-01 8:13 ` [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too" Jeff Layton
2011-11-01 10:59 ` Jeff Layton
2011-11-01 16:30 ` Tejun Heo
2011-11-01 16:49 ` Trond Myklebust
2011-11-01 16:55 ` Tejun Heo [this message]
2011-11-01 17:59 ` Oleg Nesterov
2011-11-01 18:06 ` Tejun Heo
2011-11-01 18:13 ` Oleg Nesterov
2011-11-01 18:27 ` Tejun Heo
2011-11-01 19:39 ` Oleg Nesterov
2011-11-01 19:46 ` Oleg Nesterov
2011-11-01 21:57 ` Tejun Heo
2011-11-02 11:42 ` Jeff Layton
2011-11-02 15:13 ` Oleg Nesterov
2011-11-02 16:23 ` Oleg Nesterov
2011-11-02 23:11 ` Rafael J. Wysocki
2011-11-03 11:15 ` Jeff Layton
2011-11-03 15:10 ` Oleg Nesterov
2011-11-02 17:53 ` [PATCH] wait_event_freezekillable: use freezer_do_not_count/freezer_count Oleg Nesterov
2011-11-03 10:42 ` Jeff Layton
2011-11-03 14:13 ` Tejun Heo
2011-11-03 15:27 ` Jeff Layton
2011-11-03 15:30 ` Tejun Heo
2011-11-01 18:26 ` [RFC PATCH] freezer: revert 27920651fe "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too" Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111101165535.GU18855@google.com \
--to=tj@kernel.org \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=rjw@sisk.pl \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).