From: Jim Rees <rees@umich.edu>
To: Steve Dickson <steved@redhat.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/2] nfsidmap: Added -v and -t flags
Date: Sat, 12 Nov 2011 14:15:26 -0500 [thread overview]
Message-ID: <20111112191526.GB25581@umich.edu> (raw)
In-Reply-To: <1321113346-10106-3-git-send-email-steved@redhat.com>
Steve Dickson wrote:
+ arg = malloc(sizeof(char) * strlen(argv[optind]) + 1);
+ strcpy(arg, argv[optind]);
strdup() would have been simpler. But don't re-do it just for this.
next prev parent reply other threads:[~2011-11-12 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:55 [PATCH 0/2] Added error logging and verbosity flag (ver #2) Steve Dickson
2011-11-12 15:55 ` [PATCH 1/2] nfsidmap: Added Error Logging Steve Dickson
2011-11-12 15:55 ` [PATCH 2/2] nfsidmap: Added -v and -t flags Steve Dickson
2011-11-12 19:15 ` Jim Rees [this message]
2011-11-14 15:06 ` Steve Dickson
2011-11-14 21:12 ` [PATCH 0/2] Added error logging and verbosity flag (ver #2) Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111112191526.GB25581@umich.edu \
--to=rees@umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox