From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mail-vx0-f174.google.com ([209.85.220.174]:61708 "EHLO mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753435Ab1KUUmg (ORCPT ); Mon, 21 Nov 2011 15:42:36 -0500 Date: Mon, 21 Nov 2011 12:42:30 -0800 From: Tejun Heo To: Jeff Layton Cc: rjw@sisk.pl, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, john@calva.com, trond.myklebust@netapp.com Subject: Re: [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Message-ID: <20111121204230.GE25776@google.com> References: <1321897221-2278-1-git-send-email-jlayton@redhat.com> <1321897221-2278-2-git-send-email-jlayton@redhat.com> <20111121175644.GF15314@google.com> <20111121153615.7e876801@corrin.poochiereds.net> <20111121204141.GD25776@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20111121204141.GD25776@google.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Nov 21, 2011 at 12:41:41PM -0800, Tejun Heo wrote: > Hello, Jeff. > > On Mon, Nov 21, 2011 at 03:36:15PM -0500, Jeff Layton wrote: > > I suppose you're suggesting something like this? > > > > freezer_do_not_count(); > > if (!try_to_freeze()) > > schedule(); > > freezer_count(); > > No, > > freezer_do_not_count(); > schedule(); > freezer_count(); > try_to_freeze(); > > freezer_count() may make %current eligible for freezing again, so it > has to check whether freezing condition is pending afterwards. Ooh, freezer_count() already has that. Heh, call me an idiot. The proposed code seems correct then. Thanks. -- tejun