From: Tejun Heo <tj@kernel.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: rjw@sisk.pl, linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org,
john@calva.com, trond.myklebust@netapp.com
Subject: Re: [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events
Date: Mon, 21 Nov 2011 12:46:20 -0800 [thread overview]
Message-ID: <20111121204620.GF25776@google.com> (raw)
In-Reply-To: <1321897221-2278-2-git-send-email-jlayton@redhat.com>
On Mon, Nov 21, 2011 at 12:40:20PM -0500, Jeff Layton wrote:
> /*
> + * Freezer-friendly macro around schedule() in the kernel.
> + */
> +#define freezable_schedule() \
> +({ \
> + freezer_do_not_count(); \
> + schedule(); \
> + freezer_count(); \
> +})
So, yes, this seems correct to me but I'm not really sure about the
naming. Given what freezable means for other interfaces, this is a
bit confusing to me but that could be because I know how each is
implemented. Anyone with a better name?
Also, this definitely can use a lot more detailed comment. What it's
supposed to do, how it's supposed to be used and so on.
Thank you.
--
tejun
next prev parent reply other threads:[~2011-11-21 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 17:40 [PATCH 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight Jeff Layton
2011-11-21 17:40 ` [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
2011-11-21 17:56 ` Tejun Heo
2011-11-21 20:36 ` Jeff Layton
2011-11-21 20:41 ` Tejun Heo
2011-11-21 20:42 ` Tejun Heo
2011-11-21 20:46 ` Tejun Heo [this message]
2011-11-21 20:57 ` Jeff Layton
2011-11-21 17:40 ` [PATCH 2/2] nfs: make TASK_KILLABLE sleeps attempt to freeze Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2011-10-28 6:08 [PATCH 1/2] sunrpc: make rpc_wait_bit_killable handle freeze events Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121204620.GF25776@google.com \
--to=tj@kernel.org \
--cc=jlayton@redhat.com \
--cc=john@calva.com \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).