From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
Cc: Steve Dickson <SteveD@redhat.com>, linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: nfs-utils and libnfsidmap
Date: Fri, 2 Dec 2011 10:15:12 -0500 [thread overview]
Message-ID: <20111202151512.GA14393@fieldses.org> (raw)
In-Reply-To: <CAGue13qyZPwTF1erSPwj5iaiwOOq8NGdpedS0BeMZ3JCFSveYw@mail.gmail.com>
On Fri, Dec 02, 2011 at 03:41:21PM +0100, Tigran Mkrtchyan wrote:
> On Mon, Nov 28, 2011 at 3:48 PM, Steve Dickson <SteveD@redhat.com> wrote:
> > On 11/23/2011 03:13 PM, J. Bruce Fields wrote:
> >> On Wed, Nov 23, 2011 at 08:54:06PM +0100, Tigran Mkrtchyan wrote:
> >>> Hi All,
> >>>
> >>> today was tracing a bug in nfs-utils/libnfsidmap and after a log
> >>> debugging located it and
> >>> finally realized that it's already fixed by Steve Dickson (
> >>> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=d22ef3f525d71b565fcc688557273a6cabeeb71a
> >>> ). Nevertheless during
> >>> this procedure it turned out that there is quite some code duplicated
> >>> between nfs-utils and
> >>> libnfsidmap.
> >>>
> >>> Questions:
> >>> a) why nfs-utils duplicates some part of libnfsidmap and still depends o it
> >>> b) is there readon for code duplication? Licensing or so
> >>> c) what ww need to do to get rid of duplication
> >>>
> >>> I expect the answer of 'c' will contain something like time and man power.
> >>> I am volunteering to to pend some time on it.
> >>
> >> I doubt there's any real reason for duplication.
> > Just curious as to what code we are talking about...
>
> for example
> nfs-utils/support/nfs/conffile.c => libnfsidmap/cfg.c
> nfs-utils/utils/idmapd/queue.h => libnfsidmap/queue.h
>
> probably some other files as well.
OK. I'm sure reasonable patches would be welcomed.
--b.
prev parent reply other threads:[~2011-12-02 15:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 19:54 nfs-utils and libnfsidmap Tigran Mkrtchyan
2011-11-23 20:13 ` J. Bruce Fields
2011-11-28 14:48 ` Steve Dickson
2011-11-28 17:06 ` J. Bruce Fields
2011-12-02 14:41 ` Tigran Mkrtchyan
2011-12-02 15:15 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202151512.GA14393@fieldses.org \
--to=bfields@fieldses.org \
--cc=SteveD@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=tigran.mkrtchyan@desy.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).