From: Al Viro <viro@ZenIV.linux.org.uk>
To: Maxim Uvarov <maxim.uvarov@oracle.com>
Cc: linux-nfs@vger.kernel.org, bfields@fieldses.org,
Trond.Myklebust@netapp.com, john@johnmccutchan.com,
rlove@rlove.org, eparis@parisplace.org
Subject: Re: [PATCH] NFS/INOTIFY: inotify user when deleting files on nfs
Date: Wed, 14 Dec 2011 23:22:54 +0000 [thread overview]
Message-ID: <20111214232254.GP2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1323903495-4084-2-git-send-email-maxim.uvarov@oracle.com>
On Wed, Dec 14, 2011 at 02:58:15PM -0800, Maxim Uvarov wrote:
> This issue was introduced with LTP inotify02 test.
> If file system is not NFS user inotify application
> gets IN_DELETE event. But on NFS code avoids d_delete()
> which sends this event. This patch makes notification
> on NFS the same as non-NFS. I.e. vfs_unlink still avoids
> deletion but it sends event for NFS sillyrenamed files.
> More details here:
> https://lkml.org/lkml/2011/11/29/421
NAK. Too damn ugly. And completely misses the point of inotify -
seeing events generated only by this client is going to be worthless.
Face it, inotify is broken by design for network filesystems. Any
software using it on NFS is broken; trying to paper over that is
not a good idea.
Just. Don't. Use. That. Shit.
next prev parent reply other threads:[~2011-12-14 23:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 22:58 [PATCH] NFS/INOTIFY: inotify user when deleting files on nfs Maxim Uvarov
2011-12-14 22:58 ` Maxim Uvarov
2011-12-14 23:22 ` Al Viro [this message]
2011-12-15 19:12 ` Maxim Uvarov
2011-12-15 21:32 ` Al Viro
2011-12-15 21:52 ` Myklebust, Trond
2011-12-15 22:34 ` Maxim Uvarov
2011-12-15 22:58 ` Myklebust, Trond
2011-12-15 23:27 ` Maxim Uvarov
2011-12-16 20:50 ` Stef Bon
[not found] <1323901667-3746-1-git-send-email-maxim.uvarov@oracle.com>
2011-12-15 10:42 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214232254.GP2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=bfields@fieldses.org \
--cc=eparis@parisplace.org \
--cc=john@johnmccutchan.com \
--cc=linux-nfs@vger.kernel.org \
--cc=maxim.uvarov@oracle.com \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox