From: Chuck Lever <chuck.lever@oracle.com>
To: steved@redhat.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 3/5] mountd: Plug v4root memory leak
Date: Wed, 04 Jan 2012 14:56:58 -0500 [thread overview]
Message-ID: <20120104195658.21904.84311.stgit@degas.1015granger.net> (raw)
In-Reply-To: <20120104194136.21904.36616.stgit@degas.1015granger.net>
Valgrind reports that the memory allocated for eep's e_hostname field
was not being freed. eep is not visible outside of v4root_create(),
so we don't need to strdup() that string.
Introduced by commit 3b777b0 "exports: NFSv4 pseudoroot support
routines" (Dec 1, 2009).
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
utils/mountd/v4root.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/utils/mountd/v4root.c b/utils/mountd/v4root.c
index c33a5a9..81f813b 100644
--- a/utils/mountd/v4root.c
+++ b/utils/mountd/v4root.c
@@ -83,7 +83,7 @@ v4root_create(char *path, nfs_export *export)
struct exportent *curexp = &export->m_export;
dupexportent(&eep, &pseudo_root.m_export);
- eep.e_hostname = strdup(curexp->e_hostname);
+ eep.e_hostname = curexp->e_hostname;
strncpy(eep.e_path, path, sizeof(eep.e_path));
if (strcmp(path, "/") != 0)
eep.e_flags &= ~NFSEXP_FSID;
next prev parent reply other threads:[~2012-01-04 19:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 19:56 [PATCH 0/5] Bug fixes and NFS junction support Chuck Lever
2012-01-04 19:56 ` [PATCH 1/5] configure.ac: Clean up help string for --with-statdpath Chuck Lever
2012-01-04 19:56 ` [PATCH 2/5] configure.ac: Don't check for AI_ADDRCONFIG Chuck Lever
2012-01-04 19:56 ` Chuck Lever [this message]
2012-01-04 19:57 ` [PATCH 4/5] mountd: remove newline from xlog() format specifier strings Chuck Lever
2012-01-04 19:57 ` [PATCH 5/5] mountd: Support junction management plug-ins Chuck Lever
2012-01-04 20:08 ` Jim Meyering
2012-01-04 20:40 ` Chuck Lever
2012-01-05 21:48 ` [PATCH 0/5] Bug fixes and NFS junction support Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104195658.21904.84311.stgit@degas.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).