From: Jim Rees <rees@umich.edu>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Sasha Levin <levinsasha928@gmail.com>,
linux@razik.name, Trond.Myklebust@netapp.com, penberg@kernel.org,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
Date: Sat, 7 Jan 2012 13:12:21 -0500 [thread overview]
Message-ID: <20120107181221.GA3777@umich.edu> (raw)
In-Reply-To: <5FF522E0-132E-4A6A-A40F-5CCD08AF800A@oracle.com>
Chuck Lever wrote:
On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
> Currently, we'll try mounting any device who's major device number is
> UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
> as 9p devices) but it wouldn't cause any issues since mounting the device
> as NFS would fail quickly and the code proceeded to doing the proper mount:
>
> [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
> [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
>
> Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
> mounting NFS root, which means that now we don't immediately fail and instead
> it takes an additional 90+ seconds until we stop retrying.
>
> This meant that it would take an additional 90 seconds to boot when we're not
> using a device type which gets detected in order before NFS.
The long timeouts are kind of irrelevant, in my view. The real problem is
that NFS was tried at all in this case. That behavior was not introduced
by 6829a058.
The comment does imply that 6829a048 introduced a bug, but that's not true.
It uncovered a bug that was there before.
I would change the part about "now we don't immediately fail." It didn't
immediately fail before, but the timeout was short enough that you wouldn't
notice it.
next prev parent reply other threads:[~2012-01-07 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 9:12 [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches Sasha Levin
2012-01-07 16:57 ` Chuck Lever
2012-01-07 18:12 ` Jim Rees [this message]
2012-01-09 12:14 ` Sasha Levin
2012-03-31 15:21 ` Sasha Levin
2012-03-31 15:27 ` Chuck Lever
2012-03-31 21:09 ` Myklebust, Trond
2012-03-31 21:21 ` Sasha Levin
2012-03-31 21:24 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107181221.GA3777@umich.edu \
--to=rees@umich.edu \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@razik.name \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).