* [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
@ 2012-01-07 9:12 Sasha Levin
2012-01-07 16:57 ` Chuck Lever
0 siblings, 1 reply; 9+ messages in thread
From: Sasha Levin @ 2012-01-07 9:12 UTC (permalink / raw)
To: chuck.lever, linux, Trond.Myklebust
Cc: penberg, linux-nfs, linux-kernel, Sasha Levin
Currently, we'll try mounting any device who's major device number is
UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
as 9p devices) but it wouldn't cause any issues since mounting the device
as NFS would fail quickly and the code proceeded to doing the proper mount:
[ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
[ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
mounting NFS root, which means that now we don't immediately fail and instead
it takes an additional 90+ seconds until we stop retrying.
This meant that it would take an additional 90 seconds to boot when we're not
using a device type which gets detected in order before NFS.
This patch modifies the NFS type check to require device type to be
'Root_NFS' instead of requiring the device to have an UNNAMED_MAJOR major.
This makes boot process cleaner since we now won't go through the NFS mounting
code at all when the device isn't an NFS root ("/dev/nfs").
Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
---
init/do_mounts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/init/do_mounts.c b/init/do_mounts.c
index 06225d2..da76f2c 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -475,7 +475,7 @@ void __init change_floppy(char *fmt, ...)
void __init mount_root(void)
{
#ifdef CONFIG_ROOT_NFS
- if (MAJOR(ROOT_DEV) == UNNAMED_MAJOR) {
+ if (ROOT_DEV == Root_NFS) {
if (mount_nfs_root())
return;
--
1.7.8.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-01-07 9:12 [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches Sasha Levin
@ 2012-01-07 16:57 ` Chuck Lever
2012-01-07 18:12 ` Jim Rees
0 siblings, 1 reply; 9+ messages in thread
From: Chuck Lever @ 2012-01-07 16:57 UTC (permalink / raw)
To: Sasha Levin; +Cc: linux, Trond.Myklebust, penberg, linux-nfs, linux-kernel
Hi-
On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
> Currently, we'll try mounting any device who's major device number is
> UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
> as 9p devices) but it wouldn't cause any issues since mounting the device
> as NFS would fail quickly and the code proceeded to doing the proper mount:
>
> [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
> [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
>
> Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
> mounting NFS root, which means that now we don't immediately fail and instead
> it takes an additional 90+ seconds until we stop retrying.
>
> This meant that it would take an additional 90 seconds to boot when we're not
> using a device type which gets detected in order before NFS.
The long timeouts are kind of irrelevant, in my view. The real problem is that NFS was tried at all in this case. That behavior was not introduced by 6829a058.
> This patch modifies the NFS type check to require device type to be
> 'Root_NFS' instead of requiring the device to have an UNNAMED_MAJOR major.
> This makes boot process cleaner since we now won't go through the NFS mounting
> code at all when the device isn't an NFS root ("/dev/nfs").
Agreed. I like this approach.
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> init/do_mounts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 06225d2..da76f2c 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -475,7 +475,7 @@ void __init change_floppy(char *fmt, ...)
> void __init mount_root(void)
> {
> #ifdef CONFIG_ROOT_NFS
> - if (MAJOR(ROOT_DEV) == UNNAMED_MAJOR) {
> + if (ROOT_DEV == Root_NFS) {
> if (mount_nfs_root())
> return;
>
> --
> 1.7.8.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-01-07 16:57 ` Chuck Lever
@ 2012-01-07 18:12 ` Jim Rees
2012-01-09 12:14 ` Sasha Levin
0 siblings, 1 reply; 9+ messages in thread
From: Jim Rees @ 2012-01-07 18:12 UTC (permalink / raw)
To: Chuck Lever
Cc: Sasha Levin, linux, Trond.Myklebust, penberg, linux-nfs,
linux-kernel
Chuck Lever wrote:
On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
> Currently, we'll try mounting any device who's major device number is
> UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
> as 9p devices) but it wouldn't cause any issues since mounting the device
> as NFS would fail quickly and the code proceeded to doing the proper mount:
>
> [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
> [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
>
> Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
> mounting NFS root, which means that now we don't immediately fail and instead
> it takes an additional 90+ seconds until we stop retrying.
>
> This meant that it would take an additional 90 seconds to boot when we're not
> using a device type which gets detected in order before NFS.
The long timeouts are kind of irrelevant, in my view. The real problem is
that NFS was tried at all in this case. That behavior was not introduced
by 6829a058.
The comment does imply that 6829a048 introduced a bug, but that's not true.
It uncovered a bug that was there before.
I would change the part about "now we don't immediately fail." It didn't
immediately fail before, but the timeout was short enough that you wouldn't
notice it.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-01-07 18:12 ` Jim Rees
@ 2012-01-09 12:14 ` Sasha Levin
2012-03-31 15:21 ` Sasha Levin
0 siblings, 1 reply; 9+ messages in thread
From: Sasha Levin @ 2012-01-09 12:14 UTC (permalink / raw)
To: Jim Rees
Cc: Chuck Lever, linux, Trond.Myklebust, penberg, linux-nfs,
linux-kernel
On Sat, 2012-01-07 at 13:12 -0500, Jim Rees wrote:
> Chuck Lever wrote:
>
> On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
>
> > Currently, we'll try mounting any device who's major device number is
> > UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
> > as 9p devices) but it wouldn't cause any issues since mounting the device
> > as NFS would fail quickly and the code proceeded to doing the proper mount:
> >
> > [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
> > [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
> >
> > Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
> > mounting NFS root, which means that now we don't immediately fail and instead
> > it takes an additional 90+ seconds until we stop retrying.
> >
> > This meant that it would take an additional 90 seconds to boot when we're not
> > using a device type which gets detected in order before NFS.
>
> The long timeouts are kind of irrelevant, in my view. The real problem is
> that NFS was tried at all in this case. That behavior was not introduced
> by 6829a058.
>
> The comment does imply that 6829a048 introduced a bug, but that's not true.
> It uncovered a bug that was there before.
>
> I would change the part about "now we don't immediately fail." It didn't
> immediately fail before, but the timeout was short enough that you wouldn't
> notice it.
I tried to point out that 6829a048 changed the behavior which was
described in the first paragraph, I didn't try to imply that 6829a048 is
buggy on its own.
I'm fine with changing the changelog to whatever will make it clearer.
--
Sasha.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-01-09 12:14 ` Sasha Levin
@ 2012-03-31 15:21 ` Sasha Levin
2012-03-31 15:27 ` Chuck Lever
0 siblings, 1 reply; 9+ messages in thread
From: Sasha Levin @ 2012-03-31 15:21 UTC (permalink / raw)
To: Jim Rees
Cc: Chuck Lever, linux, Trond.Myklebust, penberg, linux-nfs,
linux-kernel
ping? I saw that this one didn't get pulled into the tree.
On Mon, Jan 9, 2012 at 1:14 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> On Sat, 2012-01-07 at 13:12 -0500, Jim Rees wrote:
>> Chuck Lever wrote:
>>
>> On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
>>
>> > Currently, we'll try mounting any device who's major device number is
>> > UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
>> > as 9p devices) but it wouldn't cause any issues since mounting the device
>> > as NFS would fail quickly and the code proceeded to doing the proper mount:
>> >
>> > [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
>> > [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
>> >
>> > Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
>> > mounting NFS root, which means that now we don't immediately fail and instead
>> > it takes an additional 90+ seconds until we stop retrying.
>> >
>> > This meant that it would take an additional 90 seconds to boot when we're not
>> > using a device type which gets detected in order before NFS.
>>
>> The long timeouts are kind of irrelevant, in my view. The real problem is
>> that NFS was tried at all in this case. That behavior was not introduced
>> by 6829a058.
>>
>> The comment does imply that 6829a048 introduced a bug, but that's not true.
>> It uncovered a bug that was there before.
>>
>> I would change the part about "now we don't immediately fail." It didn't
>> immediately fail before, but the timeout was short enough that you wouldn't
>> notice it.
>
> I tried to point out that 6829a048 changed the behavior which was
> described in the first paragraph, I didn't try to imply that 6829a048 is
> buggy on its own.
>
> I'm fine with changing the changelog to whatever will make it clearer.
>
> --
>
> Sasha.
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-03-31 15:21 ` Sasha Levin
@ 2012-03-31 15:27 ` Chuck Lever
2012-03-31 21:09 ` Myklebust, Trond
0 siblings, 1 reply; 9+ messages in thread
From: Chuck Lever @ 2012-03-31 15:27 UTC (permalink / raw)
To: Trond Myklebust
Cc: Jim Rees, Sasha Levin, Lukas Razik, Pekka Enberg,
Linux NFS Mailing List, LKML Kernel
Oops. Trond? This got dropped somewhere.
On Mar 31, 2012, at 11:21 AM, Sasha Levin wrote:
> ping? I saw that this one didn't get pulled into the tree.
>
> On Mon, Jan 9, 2012 at 1:14 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>> On Sat, 2012-01-07 at 13:12 -0500, Jim Rees wrote:
>>> Chuck Lever wrote:
>>>
>>> On Jan 7, 2012, at 4:12 AM, Sasha Levin wrote:
>>>
>>> > Currently, we'll try mounting any device who's major device number is
>>> > UNNAMED_MAJOR as NFS root. This would happen for non-NFS devices as well (such
>>> > as 9p devices) but it wouldn't cause any issues since mounting the device
>>> > as NFS would fail quickly and the code proceeded to doing the proper mount:
>>> >
>>> > [ 101.522716] VFS: Unable to mount root fs via NFS, trying floppy.
>>> > [ 101.534499] VFS: Mounted root (9p filesystem) on device 0:18.
>>> >
>>> > Commit 6829a048 ("NFS: Retry mounting NFSROOT") has introduced retries when
>>> > mounting NFS root, which means that now we don't immediately fail and instead
>>> > it takes an additional 90+ seconds until we stop retrying.
>>> >
>>> > This meant that it would take an additional 90 seconds to boot when we're not
>>> > using a device type which gets detected in order before NFS.
>>>
>>> The long timeouts are kind of irrelevant, in my view. The real problem is
>>> that NFS was tried at all in this case. That behavior was not introduced
>>> by 6829a058.
>>>
>>> The comment does imply that 6829a048 introduced a bug, but that's not true.
>>> It uncovered a bug that was there before.
>>>
>>> I would change the part about "now we don't immediately fail." It didn't
>>> immediately fail before, but the timeout was short enough that you wouldn't
>>> notice it.
>>
>> I tried to point out that 6829a048 changed the behavior which was
>> described in the first paragraph, I didn't try to imply that 6829a048 is
>> buggy on its own.
>>
>> I'm fine with changing the changelog to whatever will make it clearer.
>>
>> --
>>
>> Sasha.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-03-31 15:27 ` Chuck Lever
@ 2012-03-31 21:09 ` Myklebust, Trond
2012-03-31 21:21 ` Sasha Levin
0 siblings, 1 reply; 9+ messages in thread
From: Myklebust, Trond @ 2012-03-31 21:09 UTC (permalink / raw)
To: Chuck Lever
Cc: Jim Rees, Sasha Levin, Lukas Razik, Pekka Enberg,
Linux NFS Mailing List, LKML Kernel
T24gU2F0LCAyMDEyLTAzLTMxIGF0IDExOjI3IC0wNDAwLCBDaHVjayBMZXZlciB3cm90ZToNCj4g
T29wcy4gIFRyb25kPyAgVGhpcyBnb3QgZHJvcHBlZCBzb21ld2hlcmUuDQoNCkkgZG9uJ3Qgb3du
IHRoZSAnaW5pdCcgZGlyZWN0b3J5LCBhbmQgc2luY2UgcXVpdGUgZnJhbmtseSB0aGlzIGlzbid0
DQpyZWxhdGVkIHRvIE5GUyBhdCBhbGwsIGl0IHNob3VsZCBiZSBzZW50IHRvIExpbnVzIGRpcmVj
dGx5Lg0KDQpJJ20gcXVpdGUgaGFwcHkgdG8gYWNrIHRoZSBwYXRjaCBpZiB0aGF0IHdvdWxkIGhl
bHAuDQoNCkNoZWVycw0KICBUcm9uZA0KDQo+IE9uIE1hciAzMSwgMjAxMiwgYXQgMTE6MjEgQU0s
IFNhc2hhIExldmluIHdyb3RlOg0KPiANCj4gPiBwaW5nPyBJIHNhdyB0aGF0IHRoaXMgb25lIGRp
ZG4ndCBnZXQgcHVsbGVkIGludG8gdGhlIHRyZWUuDQo+ID4gDQo+ID4gT24gTW9uLCBKYW4gOSwg
MjAxMiBhdCAxOjE0IFBNLCBTYXNoYSBMZXZpbiA8bGV2aW5zYXNoYTkyOEBnbWFpbC5jb20+IHdy
b3RlOg0KPiA+PiBPbiBTYXQsIDIwMTItMDEtMDcgYXQgMTM6MTIgLTA1MDAsIEppbSBSZWVzIHdy
b3RlOg0KPiA+Pj4gQ2h1Y2sgTGV2ZXIgd3JvdGU6DQo+ID4+PiANCj4gPj4+ICAgT24gSmFuIDcs
IDIwMTIsIGF0IDQ6MTIgQU0sIFNhc2hhIExldmluIHdyb3RlOg0KPiA+Pj4gDQo+ID4+PiAgID4g
Q3VycmVudGx5LCB3ZSdsbCB0cnkgbW91bnRpbmcgYW55IGRldmljZSB3aG8ncyBtYWpvciBkZXZp
Y2UgbnVtYmVyIGlzDQo+ID4+PiAgID4gVU5OQU1FRF9NQUpPUiBhcyBORlMgcm9vdC4gVGhpcyB3
b3VsZCBoYXBwZW4gZm9yIG5vbi1ORlMgZGV2aWNlcyBhcyB3ZWxsIChzdWNoDQo+ID4+PiAgID4g
YXMgOXAgZGV2aWNlcykgYnV0IGl0IHdvdWxkbid0IGNhdXNlIGFueSBpc3N1ZXMgc2luY2UgbW91
bnRpbmcgdGhlIGRldmljZQ0KPiA+Pj4gICA+IGFzIE5GUyB3b3VsZCBmYWlsIHF1aWNrbHkgYW5k
IHRoZSBjb2RlIHByb2NlZWRlZCB0byBkb2luZyB0aGUgcHJvcGVyIG1vdW50Og0KPiA+Pj4gICA+
DQo+ID4+PiAgID4gICBbICAxMDEuNTIyNzE2XSBWRlM6IFVuYWJsZSB0byBtb3VudCByb290IGZz
IHZpYSBORlMsIHRyeWluZyBmbG9wcHkuDQo+ID4+PiAgID4gICBbICAxMDEuNTM0NDk5XSBWRlM6
IE1vdW50ZWQgcm9vdCAoOXAgZmlsZXN5c3RlbSkgb24gZGV2aWNlIDA6MTguDQo+ID4+PiAgID4N
Cj4gPj4+ICAgPiBDb21taXQgNjgyOWEwNDggKCJORlM6IFJldHJ5IG1vdW50aW5nIE5GU1JPT1Qi
KSBoYXMgaW50cm9kdWNlZCByZXRyaWVzIHdoZW4NCj4gPj4+ICAgPiBtb3VudGluZyBORlMgcm9v
dCwgd2hpY2ggbWVhbnMgdGhhdCBub3cgd2UgZG9uJ3QgaW1tZWRpYXRlbHkgZmFpbCBhbmQgaW5z
dGVhZA0KPiA+Pj4gICA+IGl0IHRha2VzIGFuIGFkZGl0aW9uYWwgOTArIHNlY29uZHMgdW50aWwg
d2Ugc3RvcCByZXRyeWluZy4NCj4gPj4+ICAgPg0KPiA+Pj4gICA+IFRoaXMgbWVhbnQgdGhhdCBp
dCB3b3VsZCB0YWtlIGFuIGFkZGl0aW9uYWwgOTAgc2Vjb25kcyB0byBib290IHdoZW4gd2UncmUg
bm90DQo+ID4+PiAgID4gdXNpbmcgYSBkZXZpY2UgdHlwZSB3aGljaCBnZXRzIGRldGVjdGVkIGlu
IG9yZGVyIGJlZm9yZSBORlMuDQo+ID4+PiANCj4gPj4+ICAgVGhlIGxvbmcgdGltZW91dHMgYXJl
IGtpbmQgb2YgaXJyZWxldmFudCwgaW4gbXkgdmlldy4gIFRoZSByZWFsIHByb2JsZW0gaXMNCj4g
Pj4+ICAgdGhhdCBORlMgd2FzIHRyaWVkIGF0IGFsbCBpbiB0aGlzIGNhc2UuICBUaGF0IGJlaGF2
aW9yIHdhcyBub3QgaW50cm9kdWNlZA0KPiA+Pj4gICBieSA2ODI5YTA1OC4NCj4gPj4+IA0KPiA+
Pj4gVGhlIGNvbW1lbnQgZG9lcyBpbXBseSB0aGF0IDY4MjlhMDQ4IGludHJvZHVjZWQgYSBidWcs
IGJ1dCB0aGF0J3Mgbm90IHRydWUuDQo+ID4+PiBJdCB1bmNvdmVyZWQgYSBidWcgdGhhdCB3YXMg
dGhlcmUgYmVmb3JlLg0KPiA+Pj4gDQo+ID4+PiBJIHdvdWxkIGNoYW5nZSB0aGUgcGFydCBhYm91
dCAibm93IHdlIGRvbid0IGltbWVkaWF0ZWx5IGZhaWwuIiAgSXQgZGlkbid0DQo+ID4+PiBpbW1l
ZGlhdGVseSBmYWlsIGJlZm9yZSwgYnV0IHRoZSB0aW1lb3V0IHdhcyBzaG9ydCBlbm91Z2ggdGhh
dCB5b3Ugd291bGRuJ3QNCj4gPj4+IG5vdGljZSBpdC4NCj4gPj4gDQo+ID4+IEkgdHJpZWQgdG8g
cG9pbnQgb3V0IHRoYXQgNjgyOWEwNDggY2hhbmdlZCB0aGUgYmVoYXZpb3Igd2hpY2ggd2FzDQo+
ID4+IGRlc2NyaWJlZCBpbiB0aGUgZmlyc3QgcGFyYWdyYXBoLCBJIGRpZG4ndCB0cnkgdG8gaW1w
bHkgdGhhdCA2ODI5YTA0OCBpcw0KPiA+PiBidWdneSBvbiBpdHMgb3duLg0KPiA+PiANCj4gPj4g
SSdtIGZpbmUgd2l0aCBjaGFuZ2luZyB0aGUgY2hhbmdlbG9nIHRvIHdoYXRldmVyIHdpbGwgbWFr
ZSBpdCBjbGVhcmVyLg0KPiA+PiANCj4gPj4gLS0NCj4gPj4gDQo+ID4+IFNhc2hhLg0KPiA+PiAN
Cj4gPiAtLQ0KPiA+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5l
ICJ1bnN1YnNjcmliZSBsaW51eC1uZnMiIGluDQo+ID4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRv
IG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCj4gPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBo
dHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwNCj4gDQoNCi0tIA0KVHJv
bmQgTXlrbGVidXN0DQpMaW51eCBORlMgY2xpZW50IG1haW50YWluZXINCg0KTmV0QXBwDQpUcm9u
ZC5NeWtsZWJ1c3RAbmV0YXBwLmNvbQ0Kd3d3Lm5ldGFwcC5jb20NCg0K
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-03-31 21:09 ` Myklebust, Trond
@ 2012-03-31 21:21 ` Sasha Levin
2012-03-31 21:24 ` Myklebust, Trond
0 siblings, 1 reply; 9+ messages in thread
From: Sasha Levin @ 2012-03-31 21:21 UTC (permalink / raw)
To: Myklebust, Trond
Cc: Chuck Lever, Jim Rees, Lukas Razik, Pekka Enberg,
Linux NFS Mailing List, LKML Kernel, Ingo Molnar, Linus Torvalds
On Sat, Mar 31, 2012 at 11:09 PM, Myklebust, Trond
<Trond.Myklebust@netapp.com> wrote:
> On Sat, 2012-03-31 at 11:27 -0400, Chuck Lever wrote:
>> Oops. Trond? This got dropped somewhere.
>
> I don't own the 'init' directory, and since quite frankly this isn't
> related to NFS at all, it should be sent to Linus directly.
>
> I'm quite happy to ack the patch if that would help.
The patch which has triggered this whole story (6829a048 ("NFS: Retry
mounting NFSROOT")) modified init/ as well, and went in through the
NFS tree. Can't this patch follow the same path?
Anyhow, I've Cc'ed Linus in hopes that this patch can somehow find
it's way into 3.4.
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches
2012-03-31 21:21 ` Sasha Levin
@ 2012-03-31 21:24 ` Myklebust, Trond
0 siblings, 0 replies; 9+ messages in thread
From: Myklebust, Trond @ 2012-03-31 21:24 UTC (permalink / raw)
To: Sasha Levin
Cc: Chuck Lever, Jim Rees, Lukas Razik, Pekka Enberg,
Linux NFS Mailing List, LKML Kernel, Ingo Molnar, Linus Torvalds
T24gU2F0LCAyMDEyLTAzLTMxIGF0IDIzOjIxICswMjAwLCBTYXNoYSBMZXZpbiB3cm90ZToNCj4g
T24gU2F0LCBNYXIgMzEsIDIwMTIgYXQgMTE6MDkgUE0sIE15a2xlYnVzdCwgVHJvbmQNCj4gPFRy
b25kLk15a2xlYnVzdEBuZXRhcHAuY29tPiB3cm90ZToNCj4gPiBPbiBTYXQsIDIwMTItMDMtMzEg
YXQgMTE6MjcgLTA0MDAsIENodWNrIExldmVyIHdyb3RlOg0KPiA+PiBPb3BzLiAgVHJvbmQ/ICBU
aGlzIGdvdCBkcm9wcGVkIHNvbWV3aGVyZS4NCj4gPg0KPiA+IEkgZG9uJ3Qgb3duIHRoZSAnaW5p
dCcgZGlyZWN0b3J5LCBhbmQgc2luY2UgcXVpdGUgZnJhbmtseSB0aGlzIGlzbid0DQo+ID4gcmVs
YXRlZCB0byBORlMgYXQgYWxsLCBpdCBzaG91bGQgYmUgc2VudCB0byBMaW51cyBkaXJlY3RseS4N
Cj4gPg0KPiA+IEknbSBxdWl0ZSBoYXBweSB0byBhY2sgdGhlIHBhdGNoIGlmIHRoYXQgd291bGQg
aGVscC4NCj4gDQo+IFRoZSBwYXRjaCB3aGljaCBoYXMgdHJpZ2dlcmVkIHRoaXMgd2hvbGUgc3Rv
cnkgKDY4MjlhMDQ4ICgiTkZTOiBSZXRyeQ0KPiBtb3VudGluZyBORlNST09UIikpIG1vZGlmaWVk
IGluaXQvIGFzIHdlbGwsIGFuZCB3ZW50IGluIHRocm91Z2ggdGhlDQo+IE5GUyB0cmVlLiBDYW4n
dCB0aGlzIHBhdGNoIGZvbGxvdyB0aGUgc2FtZSBwYXRoPw0KDQpOby4gSXQgdG91Y2hlcyBnZW5l
cmljIGNvZGUgdW5saWtlIHRoZSBhYm92ZSBwYXRjaCwgd2hpY2ggX29ubHlfIHRvdWNoZXMNCk5G
Uy1yZWxhdGVkIGNvZGUuDQoNCj4gQW55aG93LCBJJ3ZlIENjJ2VkIExpbnVzIGluIGhvcGVzIHRo
YXQgdGhpcyBwYXRjaCBjYW4gc29tZWhvdyBmaW5kDQo+IGl0J3Mgd2F5IGludG8gMy40Lg0KDQpE
b24ndCBqdXN0IENjOiBMaW51cyBvbiB0aGlzIHRocmVhZDogc2VuZCB0aGUgcGF0Y2ggdG8gaGlt
IGRpcmVjdGx5IChhbmQNCkNjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnKS4NCg0KLS0g
DQpUcm9uZCBNeWtsZWJ1c3QNCkxpbnV4IE5GUyBjbGllbnQgbWFpbnRhaW5lcg0KDQpOZXRBcHAN
ClRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tDQp3d3cubmV0YXBwLmNvbQ0KDQo=
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-03-31 21:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-07 9:12 [PATCH] nfs: Don't try mounting device as nfs root unless type fully matches Sasha Levin
2012-01-07 16:57 ` Chuck Lever
2012-01-07 18:12 ` Jim Rees
2012-01-09 12:14 ` Sasha Levin
2012-03-31 15:21 ` Sasha Levin
2012-03-31 15:27 ` Chuck Lever
2012-03-31 21:09 ` Myklebust, Trond
2012-03-31 21:21 ` Sasha Levin
2012-03-31 21:24 ` Myklebust, Trond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).