From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from fieldses.org ([174.143.236.118]:52204 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927Ab2ASWVF (ORCPT ); Thu, 19 Jan 2012 17:21:05 -0500 Date: Thu, 19 Jan 2012 17:21:01 -0500 From: "J. Bruce Fields" To: Stanislav Kinsbursky Cc: "Trond.Myklebust@netapp.com" , "linux-nfs@vger.kernel.org" , Pavel Emelianov , "neilb@suse.de" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , James Bottomley , "davem@davemloft.net" , "devel@openvz.org" Subject: Re: [PATCH 4/5] SUNRPC: ip map cache per network namespace cleanup Message-ID: <20120119222101.GA4929@fieldses.org> References: <20120119144517.9957.59143.stgit@localhost6.localdomain6> <20120119144931.9957.78601.stgit@localhost6.localdomain6> <20120119163722.GE527@fieldses.org> <4F184E70.5070902@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <4F184E70.5070902@parallels.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jan 19, 2012 at 09:10:08PM +0400, Stanislav Kinsbursky wrote: > 19.01.2012 20:37, J. Bruce Fields пишет: > >On Thu, Jan 19, 2012 at 06:49:31PM +0400, Stanislav Kinsbursky wrote: > >>This patch converts ip_map_cache per network namespace implemenetation to the > >>same view, as other caches done in the series. > >>Besides generalization, code becomes shorter with this patch. > > > >Again, isnt' it ip_map_cache, and not one of the dynamically created > >cache details, that's being passed to the lookup routines? > > > >I may just be confused.... > > > > Nope. ip_map_cache was made per network namespace a long time ago. > But it was done in other way: no static templates - just allocation > and initialization. > But static template looks clearer to me. So I've used this approach > for other caches. And decided to update ip_map_cache management in > the same way. Going and reading the code.... OK, I see what you mean, makes sense. Thanks! --b.