linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Koen Wilde <koen@chillheid.nl>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
	"J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"Adamson, Andy" <William.Adamson@netapp.com>
Subject: Re: oops when copying a file from a nfs mount
Date: Sat, 04 Feb 2012 14:37:45 +0100	[thread overview]
Message-ID: <20120204133745.B3607405DC@mail.chillheid.nl> (raw)
In-Reply-To: <1328312712.5335.17.camel@lade.trondhjem.org>

On Fri, 3 Feb 2012 23:45:12 +0000, "Myklebust, Trond" <Trond.Myklebust@netapp.com> wrote:
> It is obvious: firstly acl_scratch is only needed (and allocated) if the
> npages > 1. Secondly, the call to xdr_set_scratch_buffer() needs to be
> done in the decoder, not the encoder...
> 
> The following patch should fix it.
> 
I can confirm the oops indeed doesn't occur anymore after applying this patch
to v3.2.2 :)

-- Koen

      reply	other threads:[~2012-02-04 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-03 22:36 oops when copying a file from a nfs mount koen
2012-02-03 23:08 ` J. Bruce Fields
2012-02-03 23:24   ` Koen Wilde
2012-02-04  0:11     ` J. Bruce Fields
2012-02-03 23:45   ` Myklebust, Trond
2012-02-04 13:37     ` Koen Wilde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120204133745.B3607405DC@mail.chillheid.nl \
    --to=koen@chillheid.nl \
    --cc=Trond.Myklebust@netapp.com \
    --cc=William.Adamson@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).