linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* oops when copying a file from a nfs mount
@ 2012-02-03 22:36 koen
  2012-02-03 23:08 ` J. Bruce Fields
  0 siblings, 1 reply; 6+ messages in thread
From: koen @ 2012-02-03 22:36 UTC (permalink / raw)
  To: J. Bruce Fields, Neil Brown; +Cc: linux-nfs

Hi,

Since updating from kernel 3.2.1 to 3.2.2, copying a file from a nfs mount
using `cp` results in a kernel oops. Copying the same file with `cat
/nfsmount/file > /local/file` gives no problems.

I can reliably trigger the oops with a simple:

    cp /nfsmount/file /local/dir

System information:

    % cat /proc/version
    Linux version 3.2.2-1-vanilla (koen@pino) (gcc version 4.6.2 20120120 (prerelease) (GCC) ) #1 SMP PREEMPT Fri Feb 3 01:51:55 CET 2012

    % zgrep '^CONFIG_NFS' /proc/config.gz
    CONFIG_NFS_FS=m
    CONFIG_NFS_V3=y
    CONFIG_NFS_V3_ACL=y
    CONFIG_NFS_V4=y
    CONFIG_NFS_FSCACHE=y
    CONFIG_NFS_USE_KERNEL_DNS=y
    CONFIG_NFSD=m
    CONFIG_NFSD_V2_ACL=y
    CONFIG_NFSD_V3=y
    CONFIG_NFSD_V3_ACL=y
    CONFIG_NFSD_V4=y
    CONFIG_NFS_ACL_SUPPORT=m
    CONFIG_NFS_COMMON=y

    % ./ver_linux
    Linux pino 3.2.2-1-vanilla #1 SMP PREEMPT Fri Feb 3 01:51:55 CET 2012 i686 Intel(R) Celeron(R) CPU E1200 @ 1.60GHz GenuineIntel GNU/Linux
     
    Gnu C                  4.6.2
    Gnu make               3.82
    binutils               2.22.0.20111227
    util-linux             2.20.1
    mount                  support
    module-init-tools      4
    e2fsprogs              1.42
    jfsutils               1.1.15
    reiserfsprogs          3.6.21
    xfsprogs               3.1.7
    pcmciautils            018
    PPP                    2.4.5
    Linux C Library        2.15
    Dynamic linker (ldd)   2.15
    Linux C++ Library      6.0.16
    Procps                 3.2.8
    Net-tools              1.60
    Kbd                    1.15.3
    Sh-utils               8.15
    Modules Loaded         ipv6 ext3 jbd joydev snd_usb_audio snd_usbmidi_lib snd_rawmidi snd_seq_device usbhid hid wacom snd_hda_codec_hdmi btusb bluetooth rfkill ppdev evdev snd_hda_codec_realtek radeon snd_hda_intel snd_hda_codec drm_kms_helper snd_pcm atl1 iTCO_wdt iTCO_vendor_support pcspkr ttm i2c_i801 serio_raw snd_page_alloc snd_hwdep snd_timer snd drm soundcore mii i2c_algo_bit i2c_core intel_agp intel_gtt agpgart floppy parport_pc parport asus_atk0110 nfs button nfs_acl lockd auth_rpcgss sunrpc fscache cpufreq_ondemand acpi_cpufreq mperf processor freq_table ext4 crc16 jbd2 mbcache dm_mod sd_mod pata_acpi ata_piix libata uhci_hcd scsi_mod ehci_hcd usbcore usb_common

    % grep nfs /proc/mounts
    servername:/data /data nfs4 rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=172.16.1.84,minorversion=0,local_lock=none,addr=172.16.1.1 0 0

Trace:

    Feb  3 03:45:23 pino kernel: [ 2931.910546] *pde = 00000000 
    Feb  3 03:45:23 pino kernel: [ 2931.910626] Modules linked in: ipv6 ext3 jbd joydev snd_usb_audio snd_usbmidi_lib usbhid snd_rawmidi snd_seq_device hid wacom btusb bluetooth rfkill snd_hda_codec_hdmi ppdev radeon evdev snd_hda_codec_realtek drm_kms_helper ttm snd_hda_intel iTCO_wdt iTCO_vendor_support drm pcspkr snd_hda_codec serio_raw i2c_i801 snd_pcm snd_page_alloc snd_hwdep i2c_algo_bit i2c_core snd_timer intel_agp atl1 intel_gtt snd agpgart mii soundcore floppy parport_pc parport asus_atk0110 button nfs nfs_acl lockd auth_rpcgss sunrpc fscache cpufreq_ondemand acpi_cpufreq mperf processor freq_table ext4 crc16 jbd2 mbcache dm_mod sd_mod pata_acpi ata_piix libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common
    Feb  3 03:45:23 pino kernel: [ 2931.911382] 
    Feb  3 03:45:23 pino kernel: [ 2931.911400] Pid: 2003, comm: cp Not tainted 3.2.2-1-vanilla #1 System manufacturer System Product Name/P5B-MX
    Feb  3 03:45:23 pino kernel: [ 2931.911500] EIP: 0060:[<c01f3c00>] EFLAGS: 00010282 CPU: 1
    Feb  3 03:45:23 pino kernel: [ 2931.911552] EIP is at page_address+0x10/0xe0
    Feb  3 03:45:23 pino kernel: [ 2931.911592] EAX: 00000000 EBX: c6699dd8 ECX: f2c6b1e4 EDX: 00000038
    Feb  3 03:45:23 pino kernel: [ 2931.911648] ESI: 00000000 EDI: 00000000 EBP: c6699c18 ESP: c6699c08
    Feb  3 03:45:23 pino kernel: [ 2931.911704]  DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
    Feb  3 03:45:23 pino kernel: [ 2931.911839]  00001000 c6699dd8 00000000 c6699c78 c6699c54 f8666b45 00000000 00001000
    Feb  3 03:45:23 pino kernel: [ 2931.911934]  0000000e 00000000 00000002 f2c6b084 00000000 00000000 0000006e 00000000
    Feb  3 03:45:23 pino kernel: [ 2931.912028]  f584c700 f59cde00 f8666ab0 c6699ca0 f855c4a5 f2c6b020 c6699c7c f855ca07
    Feb  3 03:45:23 pino kernel: [ 2931.912161]  [<f8666b45>] nfs4_xdr_enc_getacl+0x95/0xc0 [nfs]
    Feb  3 03:45:23 pino kernel: [ 2931.912224]  [<f8666ab0>] ? nfs4_xdr_enc_fs_locations+0xf0/0xf0 [nfs]
    Feb  3 03:45:23 pino kernel: [ 2931.912292]  [<f855c4a5>] rpcauth_wrap_req+0x75/0xc0 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912351]  [<f855ca07>] ? unx_marshal+0x47/0xc0 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912404]  [<c01d9513>] ? mempool_alloc_slab+0x13/0x20
    Feb  3 03:45:23 pino kernel: [ 2931.912460]  [<f8553b6e>] call_transmit+0x14e/0x250 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912513]  [<c01d978b>] ? mempool_alloc+0x3b/0xf0
    Feb  3 03:45:23 pino kernel: [ 2931.912565]  [<f855ad12>] __rpc_execute+0x52/0x2a0 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912618]  [<c0167c23>] ? wake_up_bit+0x23/0x30
    Feb  3 03:45:23 pino kernel: [ 2931.912668]  [<f855b3b8>] rpc_execute+0x38/0x40 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912724]  [<f8553fe9>] rpc_run_task+0x59/0x70 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912778]  [<f85540fc>] rpc_call_sync+0x3c/0x60 [sunrpc]
    Feb  3 03:45:23 pino kernel: [ 2931.912840]  [<f865e283>] _nfs4_call_sync+0x23/0x30 [nfs]
    Feb  3 03:45:23 pino kernel: [ 2931.912899]  [<f865d0a6>] __nfs4_get_acl_uncached+0x186/0x290 [nfs]
    Feb  3 03:45:23 pino kernel: [ 2931.912968]  [<f865f6e4>] nfs4_xattr_get_nfs4_acl+0xe4/0x150 [nfs]
    Feb  3 03:45:23 pino kernel: [ 2931.913028]  [<c0240f96>] generic_getxattr+0x46/0x60
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0240f50>] ? xattr_resolve_name+0x80/0x80
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02414f0>] vfs_getxattr+0x80/0xb0
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02415ac>] getxattr+0x8c/0x110
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0230cda>] ? path_openat+0xca/0x350
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c01f7a01>] ? handle_pte_fault+0xe1/0x8e0
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0231071>] ? do_filp_open+0x31/0x80
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0222531>] ? do_sys_open+0x161/0x1b0
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02416fb>] ? listxattr+0x5b/0xb0
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0241e76>] sys_fgetxattr+0x46/0x70
    Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c047c39f>] sysenter_do_call+0x12/0x28
    Feb  3 03:45:23 pino kernel: [ 2931.932919] ---[ end trace 2749b252593ffc7f ]---

Please let me know if you need any other information, or if I can do anything else to help (I'm not a programmer).

Regards,
Koen Wilde

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: oops when copying a file from a nfs mount
  2012-02-03 22:36 oops when copying a file from a nfs mount koen
@ 2012-02-03 23:08 ` J. Bruce Fields
  2012-02-03 23:24   ` Koen Wilde
  2012-02-03 23:45   ` Myklebust, Trond
  0 siblings, 2 replies; 6+ messages in thread
From: J. Bruce Fields @ 2012-02-03 23:08 UTC (permalink / raw)
  To: koen; +Cc: Neil Brown, linux-nfs, Andy Adamson

On Fri, Feb 03, 2012 at 11:36:04PM +0100, koen@chillheid.nl wrote:
> Hi,
> 
> Since updating from kernel 3.2.1 to 3.2.2, copying a file from a nfs mount
> using `cp` results in a kernel oops. Copying the same file with `cat
> /nfsmount/file > /local/file` gives no problems.

Hm, the oops is in getattr encoding, and doing a

	gitk v3.2.1..v3.2.2 fs/nfs net/sunrpc

turns up one commit that modifies that code:

	628fc192adbaae0c6178b9015fb916ce61d72b36 "NFSv4: include bitmap
	in nfsv4 get acl data"

I haven't looked at that, but maybe the problem will be obvious to
Andy....

> 
> I can reliably trigger the oops with a simple:
> 
>     cp /nfsmount/file /local/dir
> 
> System information:
> 
>     % cat /proc/version
>     Linux version 3.2.2-1-vanilla (koen@pino) (gcc version 4.6.2 20120120 (prerelease) (GCC) ) #1 SMP PREEMPT Fri Feb 3 01:51:55 CET 2012
> 
>     % zgrep '^CONFIG_NFS' /proc/config.gz
>     CONFIG_NFS_FS=m
>     CONFIG_NFS_V3=y
>     CONFIG_NFS_V3_ACL=y
>     CONFIG_NFS_V4=y
>     CONFIG_NFS_FSCACHE=y
>     CONFIG_NFS_USE_KERNEL_DNS=y
>     CONFIG_NFSD=m
>     CONFIG_NFSD_V2_ACL=y
>     CONFIG_NFSD_V3=y
>     CONFIG_NFSD_V3_ACL=y
>     CONFIG_NFSD_V4=y
>     CONFIG_NFS_ACL_SUPPORT=m
>     CONFIG_NFS_COMMON=y
> 
>     % ./ver_linux
>     Linux pino 3.2.2-1-vanilla #1 SMP PREEMPT Fri Feb 3 01:51:55 CET 2012 i686 Intel(R) Celeron(R) CPU E1200 @ 1.60GHz GenuineIntel GNU/Linux
>      
>     Gnu C                  4.6.2
>     Gnu make               3.82
>     binutils               2.22.0.20111227
>     util-linux             2.20.1
>     mount                  support
>     module-init-tools      4
>     e2fsprogs              1.42
>     jfsutils               1.1.15
>     reiserfsprogs          3.6.21
>     xfsprogs               3.1.7
>     pcmciautils            018
>     PPP                    2.4.5
>     Linux C Library        2.15
>     Dynamic linker (ldd)   2.15
>     Linux C++ Library      6.0.16
>     Procps                 3.2.8
>     Net-tools              1.60
>     Kbd                    1.15.3
>     Sh-utils               8.15
>     Modules Loaded         ipv6 ext3 jbd joydev snd_usb_audio snd_usbmidi_lib snd_rawmidi snd_seq_device usbhid hid wacom snd_hda_codec_hdmi btusb bluetooth rfkill ppdev evdev snd_hda_codec_realtek radeon snd_hda_intel snd_hda_codec drm_kms_helper snd_pcm atl1 iTCO_wdt iTCO_vendor_support pcspkr ttm i2c_i801 serio_raw snd_page_alloc snd_hwdep snd_timer snd drm soundcore mii i2c_algo_bit i2c_core intel_agp intel_gtt agpgart floppy parport_pc parport asus_atk0110 nfs button nfs_acl lockd auth_rpcgss sunrpc fscache cpufreq_ondemand acpi_cpufreq mperf processor freq_table ext4 crc16 jbd2 mbcache dm_mod sd_mod pata_acpi ata_piix libata uhci_hcd scsi_mod ehci_hcd usbcore usb_common
> 
>     % grep nfs /proc/mounts
>     servername:/data /data nfs4 rw,nosuid,nodev,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=172.16.1.84,minorversion=0,local_lock=none,addr=172.16.1.1 0 0
> 
> Trace:
> 

Is this really the start of the trace, or were there any lines before?

>     Feb  3 03:45:23 pino kernel: [ 2931.910546] *pde = 00000000 
>     Feb  3 03:45:23 pino kernel: [ 2931.910626] Modules linked in: ipv6 ext3 jbd joydev snd_usb_audio snd_usbmidi_lib usbhid snd_rawmidi snd_seq_device hid wacom btusb bluetooth rfkill snd_hda_codec_hdmi ppdev radeon evdev snd_hda_codec_realtek drm_kms_helper ttm snd_hda_intel iTCO_wdt iTCO_vendor_support drm pcspkr snd_hda_codec serio_raw i2c_i801 snd_pcm snd_page_alloc snd_hwdep i2c_algo_bit i2c_core snd_timer intel_agp atl1 intel_gtt snd agpgart mii soundcore floppy parport_pc parport asus_atk0110 button nfs nfs_acl lockd auth_rpcgss sunrpc fscache cpufreq_ondemand acpi_cpufreq mperf processor freq_table ext4 crc16 jbd2 mbcache dm_mod sd_mod pata_acpi ata_piix libata scsi_mod uhci_hcd ehci_hcd usbcore usb_common
>     Feb  3 03:45:23 pino kernel: [ 2931.911382] 
>     Feb  3 03:45:23 pino kernel: [ 2931.911400] Pid: 2003, comm: cp Not tainted 3.2.2-1-vanilla #1 System manufacturer System Product Name/P5B-MX
>     Feb  3 03:45:23 pino kernel: [ 2931.911500] EIP: 0060:[<c01f3c00>] EFLAGS: 00010282 CPU: 1
>     Feb  3 03:45:23 pino kernel: [ 2931.911552] EIP is at page_address+0x10/0xe0
>     Feb  3 03:45:23 pino kernel: [ 2931.911592] EAX: 00000000 EBX: c6699dd8 ECX: f2c6b1e4 EDX: 00000038
>     Feb  3 03:45:23 pino kernel: [ 2931.911648] ESI: 00000000 EDI: 00000000 EBP: c6699c18 ESP: c6699c08
>     Feb  3 03:45:23 pino kernel: [ 2931.911704]  DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
>     Feb  3 03:45:23 pino kernel: [ 2931.911839]  00001000 c6699dd8 00000000 c6699c78 c6699c54 f8666b45 00000000 00001000
>     Feb  3 03:45:23 pino kernel: [ 2931.911934]  0000000e 00000000 00000002 f2c6b084 00000000 00000000 0000006e 00000000
>     Feb  3 03:45:23 pino kernel: [ 2931.912028]  f584c700 f59cde00 f8666ab0 c6699ca0 f855c4a5 f2c6b020 c6699c7c f855ca07
>     Feb  3 03:45:23 pino kernel: [ 2931.912161]  [<f8666b45>] nfs4_xdr_enc_getacl+0x95/0xc0 [nfs]
>     Feb  3 03:45:23 pino kernel: [ 2931.912224]  [<f8666ab0>] ? nfs4_xdr_enc_fs_locations+0xf0/0xf0 [nfs]
>     Feb  3 03:45:23 pino kernel: [ 2931.912292]  [<f855c4a5>] rpcauth_wrap_req+0x75/0xc0 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912351]  [<f855ca07>] ? unx_marshal+0x47/0xc0 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912404]  [<c01d9513>] ? mempool_alloc_slab+0x13/0x20
>     Feb  3 03:45:23 pino kernel: [ 2931.912460]  [<f8553b6e>] call_transmit+0x14e/0x250 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912513]  [<c01d978b>] ? mempool_alloc+0x3b/0xf0
>     Feb  3 03:45:23 pino kernel: [ 2931.912565]  [<f855ad12>] __rpc_execute+0x52/0x2a0 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912618]  [<c0167c23>] ? wake_up_bit+0x23/0x30
>     Feb  3 03:45:23 pino kernel: [ 2931.912668]  [<f855b3b8>] rpc_execute+0x38/0x40 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912724]  [<f8553fe9>] rpc_run_task+0x59/0x70 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912778]  [<f85540fc>] rpc_call_sync+0x3c/0x60 [sunrpc]
>     Feb  3 03:45:23 pino kernel: [ 2931.912840]  [<f865e283>] _nfs4_call_sync+0x23/0x30 [nfs]
>     Feb  3 03:45:23 pino kernel: [ 2931.912899]  [<f865d0a6>] __nfs4_get_acl_uncached+0x186/0x290 [nfs]
>     Feb  3 03:45:23 pino kernel: [ 2931.912968]  [<f865f6e4>] nfs4_xattr_get_nfs4_acl+0xe4/0x150 [nfs]
>     Feb  3 03:45:23 pino kernel: [ 2931.913028]  [<c0240f96>] generic_getxattr+0x46/0x60
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0240f50>] ? xattr_resolve_name+0x80/0x80
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02414f0>] vfs_getxattr+0x80/0xb0
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02415ac>] getxattr+0x8c/0x110
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0230cda>] ? path_openat+0xca/0x350
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c01f7a01>] ? handle_pte_fault+0xe1/0x8e0
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0231071>] ? do_filp_open+0x31/0x80
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c022d39b>] ? putname+0x2b/0x40
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0222531>] ? do_sys_open+0x161/0x1b0
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c02416fb>] ? listxattr+0x5b/0xb0
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c0241e76>] sys_fgetxattr+0x46/0x70
>     Feb  3 03:45:23 pino kernel: [ 2931.913057]  [<c047c39f>] sysenter_do_call+0x12/0x28
>     Feb  3 03:45:23 pino kernel: [ 2931.932919] ---[ end trace 2749b252593ffc7f ]---
> 
> Please let me know if you need any other information, or if I can do anything else to help (I'm not a programmer).

But I take it you're comfortable building a kernel from source?  If so,
getting a stable git repo, then:

	git checkout v3.2.2
	git revert 628fc192adbaae0c6178b9015fb916ce61d72b36

and then testing the resulting kernel--it'd be interesting to know if
the bug goes away.

--b.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: oops when copying a file from a nfs mount
  2012-02-03 23:08 ` J. Bruce Fields
@ 2012-02-03 23:24   ` Koen Wilde
  2012-02-04  0:11     ` J. Bruce Fields
  2012-02-03 23:45   ` Myklebust, Trond
  1 sibling, 1 reply; 6+ messages in thread
From: Koen Wilde @ 2012-02-03 23:24 UTC (permalink / raw)
  To: J. Bruce Fields; +Cc: Neil Brown, linux-nfs, Andy Adamson

On Fri, 3 Feb 2012 18:08:11 -0500, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> 
> Is this really the start of the trace, or were there any lines before?
> 

This is really the start of the trace as it appears in syslog's logs. On
the physical screen it had some extra lines on top though (I'm typing this
over from a photo):

    BUG: unable to handle kernel NULL pointer dereference at   (null)
    IP: [<c01f3c00>] page_address+0x10/0xe0
    << continuing from here with the *pde line >>

> But I take it you're comfortable building a kernel from source?  If so,
> getting a stable git repo, then:
> 
> 	git checkout v3.2.2
> 	git revert 628fc192adbaae0c6178b9015fb916ce61d72b36
> 
> and then testing the resulting kernel--it'd be interesting to know if
> the bug goes away.

Sure, I can build a kernel from source:) I'll get back to you with the
results.

-- Koen

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: oops when copying a file from a nfs mount
  2012-02-03 23:08 ` J. Bruce Fields
  2012-02-03 23:24   ` Koen Wilde
@ 2012-02-03 23:45   ` Myklebust, Trond
  2012-02-04 13:37     ` Koen Wilde
  1 sibling, 1 reply; 6+ messages in thread
From: Myklebust, Trond @ 2012-02-03 23:45 UTC (permalink / raw)
  To: J. Bruce Fields
  Cc: koen@chillheid.nl, Neil Brown, linux-nfs@vger.kernel.org,
	Adamson, Andy

T24gRnJpLCAyMDEyLTAyLTAzIGF0IDE4OjA4IC0wNTAwLCBKLiBCcnVjZSBGaWVsZHMgd3JvdGU6
DQo+IE9uIEZyaSwgRmViIDAzLCAyMDEyIGF0IDExOjM2OjA0UE0gKzAxMDAsIGtvZW5AY2hpbGxo
ZWlkLm5sIHdyb3RlOg0KPiA+IEhpLA0KPiA+IA0KPiA+IFNpbmNlIHVwZGF0aW5nIGZyb20ga2Vy
bmVsIDMuMi4xIHRvIDMuMi4yLCBjb3B5aW5nIGEgZmlsZSBmcm9tIGEgbmZzIG1vdW50DQo+ID4g
dXNpbmcgYGNwYCByZXN1bHRzIGluIGEga2VybmVsIG9vcHMuIENvcHlpbmcgdGhlIHNhbWUgZmls
ZSB3aXRoIGBjYXQNCj4gPiAvbmZzbW91bnQvZmlsZSA+IC9sb2NhbC9maWxlYCBnaXZlcyBubyBw
cm9ibGVtcy4NCj4gDQo+IEhtLCB0aGUgb29wcyBpcyBpbiBnZXRhdHRyIGVuY29kaW5nLCBhbmQg
ZG9pbmcgYQ0KPiANCj4gCWdpdGsgdjMuMi4xLi52My4yLjIgZnMvbmZzIG5ldC9zdW5ycGMNCj4g
DQo+IHR1cm5zIHVwIG9uZSBjb21taXQgdGhhdCBtb2RpZmllcyB0aGF0IGNvZGU6DQo+IA0KPiAJ
NjI4ZmMxOTJhZGJhYWUwYzYxNzhiOTAxNWZiOTE2Y2U2MWQ3MmIzNiAiTkZTdjQ6IGluY2x1ZGUg
Yml0bWFwDQo+IAlpbiBuZnN2NCBnZXQgYWNsIGRhdGEiDQo+IA0KPiBJIGhhdmVuJ3QgbG9va2Vk
IGF0IHRoYXQsIGJ1dCBtYXliZSB0aGUgcHJvYmxlbSB3aWxsIGJlIG9idmlvdXMgdG8NCj4gQW5k
eS4uLi4NCg0KSXQgaXMgb2J2aW91czogZmlyc3RseSBhY2xfc2NyYXRjaCBpcyBvbmx5IG5lZWRl
ZCAoYW5kIGFsbG9jYXRlZCkgaWYgdGhlDQpucGFnZXMgPiAxLiBTZWNvbmRseSwgdGhlIGNhbGwg
dG8geGRyX3NldF9zY3JhdGNoX2J1ZmZlcigpIG5lZWRzIHRvIGJlDQpkb25lIGluIHRoZSBkZWNv
ZGVyLCBub3QgdGhlIGVuY29kZXIuLi4NCg0KVGhlIGZvbGxvd2luZyBwYXRjaCBzaG91bGQgZml4
IGl0Lg0KDQo4PC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tDQpGcm9tIDA3NGQ4NTdkZWQ3ZGYx
MDliYTY5Njg1OTk2NGM4ZDU4NTIxNzVkYWQgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAxDQpGcm9t
OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KRGF0ZTogRnJp
LCAzIEZlYiAyMDEyIDE4OjMwOjUzIC0wNTAwDQpTdWJqZWN0OiBbUEFUQ0hdIE5GU3Y0OiBGaXgg
YW4gT29wcyBpbiB0aGUgTkZTdjQgZ2V0YWNsIGNvZGUNCg0KQ29tbWl0IGJmMTE4YTM0MmYxMGRh
ZmU0NGIxNDQ1MWExMzkyYzMyNTQ2MjlhMWYgKE5GU3Y0OiBpbmNsdWRlIGJpdG1hcA0KaW4gbmZz
djQgZ2V0IGFjbCBkYXRhKSBpbnRyb2R1Y2VzIHRoZSAnYWNsX3NjcmF0Y2gnIHBhZ2UgZm9yIHRo
ZSBjYXNlDQp3aGVyZSB3ZSBtYXkgbmVlZCB0byBkZWNvZGUgbXVsdGktcGFnZSBkYXRhLiBIb3dl
dmVyIGl0IGZhaWxzIHRvIHRha2UNCmludG8gYWNjb3VudCB0aGUgZmFjdCB0aGF0IHRoZSB2YXJp
YWJsZSBtYXkgYmUgTlVMTCAoZm9yIHRoZSBjYXNlIHdoZXJlDQp3ZSdyZSBub3QgZG9pbmcgbXVs
dGktcGFnZSBkZWNvZGUpLCBhbmQgaXQgYWxzbyBhdHRhY2hlcyBpdCB0byB0aGUNCmVuY29kaW5n
IHhkcl9zdHJlYW0gcmF0aGVyIHRoYW4gdGhlIGRlY29kaW5nIG9uZS4NCg0KVGhlIGltbWVkaWF0
ZSByZXN1bHQgaXMgYW4gT29wcyBpbiBuZnM0X3hkcl9lbmNfZ2V0YWNsIGR1ZSB0byB0aGUNCmNh
bGwgdG8gcGFnZV9hZGRyZXNzKCkgd2l0aCBhIE5VTEwgcGFnZSBwb2ludGVyLg0KDQpTaWduZWQt
b2ZmLWJ5OiBUcm9uZCBNeWtsZWJ1c3QgPFRyb25kLk15a2xlYnVzdEBuZXRhcHAuY29tPg0KQ2M6
IEFuZHkgQWRhbXNvbiA8YW5kcm9zQG5ldGFwcC5jb20+DQpDYzogc3RhYmxlQHZnZXIua2VybmVs
Lm9yZw0KLS0tDQogZnMvbmZzL25mczRwcm9jLmMgICAgICAgfCAgICA4ICsrKystLS0tDQogZnMv
bmZzL25mczR4ZHIuYyAgICAgICAgfCAgICAzICsrLQ0KIGluY2x1ZGUvbGludXgvbmZzX3hkci5o
IHwgICAgMiArLQ0KIDMgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9u
cygtKQ0KDQpkaWZmIC0tZ2l0IGEvZnMvbmZzL25mczRwcm9jLmMgYi9mcy9uZnMvbmZzNHByb2Mu
Yw0KaW5kZXggZjBjODQ5Yy4uZDIwMmUwNCAxMDA2NDQNCi0tLSBhL2ZzL25mcy9uZnM0cHJvYy5j
DQorKysgYi9mcy9uZnMvbmZzNHByb2MuYw0KQEAgLTM1NzUsOCArMzU3NSw4IEBAIHN0YXRpYyBz
c2l6ZV90IF9fbmZzNF9nZXRfYWNsX3VuY2FjaGVkKHN0cnVjdCBpbm9kZSAqaW5vZGUsIHZvaWQg
KmJ1Ziwgc2l6ZV90IGJ1DQogCX0NCiAJaWYgKG5wYWdlcyA+IDEpIHsNCiAJCS8qIGZvciBkZWNv
ZGluZyBhY3Jvc3MgcGFnZXMgKi8NCi0JCWFyZ3MuYWNsX3NjcmF0Y2ggPSBhbGxvY19wYWdlKEdG
UF9LRVJORUwpOw0KLQkJaWYgKCFhcmdzLmFjbF9zY3JhdGNoKQ0KKwkJcmVzLmFjbF9zY3JhdGNo
ID0gYWxsb2NfcGFnZShHRlBfS0VSTkVMKTsNCisJCWlmICghcmVzLmFjbF9zY3JhdGNoKQ0KIAkJ
CWdvdG8gb3V0X2ZyZWU7DQogCX0NCiAJYXJncy5hY2xfbGVuID0gbnBhZ2VzICogUEFHRV9TSVpF
Ow0KQEAgLTM2MTIsOCArMzYxMiw4IEBAIG91dF9mcmVlOg0KIAlmb3IgKGkgPSAwOyBpIDwgbnBh
Z2VzOyBpKyspDQogCQlpZiAocGFnZXNbaV0pDQogCQkJX19mcmVlX3BhZ2UocGFnZXNbaV0pOw0K
LQlpZiAoYXJncy5hY2xfc2NyYXRjaCkNCi0JCV9fZnJlZV9wYWdlKGFyZ3MuYWNsX3NjcmF0Y2gp
Ow0KKwlpZiAocmVzLmFjbF9zY3JhdGNoKQ0KKwkJX19mcmVlX3BhZ2UocmVzLmFjbF9zY3JhdGNo
KTsNCiAJcmV0dXJuIHJldDsNCiB9DQogDQpkaWZmIC0tZ2l0IGEvZnMvbmZzL25mczR4ZHIuYyBi
L2ZzL25mcy9uZnM0eGRyLmMNCmluZGV4IDk1ZTkyZTQuLmMwNDdiZWMgMTAwNjQ0DQotLS0gYS9m
cy9uZnMvbmZzNHhkci5jDQorKysgYi9mcy9uZnMvbmZzNHhkci5jDQpAQCAtMjUyMiw3ICsyNTIy
LDYgQEAgc3RhdGljIHZvaWQgbmZzNF94ZHJfZW5jX2dldGFjbChzdHJ1Y3QgcnBjX3Jxc3QgKnJl
cSwgc3RydWN0IHhkcl9zdHJlYW0gKnhkciwNCiANCiAJeGRyX2lubGluZV9wYWdlcygmcmVxLT5y
cV9yY3ZfYnVmLCByZXBsZW4gPDwgMiwNCiAJCWFyZ3MtPmFjbF9wYWdlcywgYXJncy0+YWNsX3Bn
YmFzZSwgYXJncy0+YWNsX2xlbik7DQotCXhkcl9zZXRfc2NyYXRjaF9idWZmZXIoeGRyLCBwYWdl
X2FkZHJlc3MoYXJncy0+YWNsX3NjcmF0Y2gpLCBQQUdFX1NJWkUpOw0KIA0KIAllbmNvZGVfbm9w
cygmaGRyKTsNCiB9DQpAQCAtNjA0MSw2ICs2MDQwLDggQEAgbmZzNF94ZHJfZGVjX2dldGFjbChz
dHJ1Y3QgcnBjX3Jxc3QgKnJxc3RwLCBzdHJ1Y3QgeGRyX3N0cmVhbSAqeGRyLA0KIAlzdGF0dXMg
PSBkZWNvZGVfcHV0ZmgoeGRyKTsNCiAJaWYgKHN0YXR1cykNCiAJCWdvdG8gb3V0Ow0KKwlpZiAo
cmVzLT5hY2xfc2NyYXRjaCAhPSBOVUxMKQ0KKwkJeGRyX3NldF9zY3JhdGNoX2J1ZmZlcih4ZHIs
IHBhZ2VfYWRkcmVzcyhyZXMtPmFjbF9zY3JhdGNoKSwgUEFHRV9TSVpFKTsNCiAJc3RhdHVzID0g
ZGVjb2RlX2dldGFjbCh4ZHIsIHJxc3RwLCByZXMpOw0KIA0KIG91dDoNCmRpZmYgLS1naXQgYS9p
bmNsdWRlL2xpbnV4L25mc194ZHIuaCBiL2luY2x1ZGUvbGludXgvbmZzX3hkci5oDQppbmRleCBh
NzY0Y2VmLi5kNmJhOWExIDEwMDY0NA0KLS0tIGEvaW5jbHVkZS9saW51eC9uZnNfeGRyLmgNCisr
KyBiL2luY2x1ZGUvbGludXgvbmZzX3hkci5oDQpAQCAtNjE0LDcgKzYxNCw2IEBAIHN0cnVjdCBu
ZnNfZ2V0YWNsYXJncyB7DQogCXNpemVfdAkJCQlhY2xfbGVuOw0KIAl1bnNpZ25lZCBpbnQJCQlh
Y2xfcGdiYXNlOw0KIAlzdHJ1Y3QgcGFnZSAqKgkJCWFjbF9wYWdlczsNCi0Jc3RydWN0IHBhZ2Ug
KgkJCWFjbF9zY3JhdGNoOw0KIAlzdHJ1Y3QgbmZzNF9zZXF1ZW5jZV9hcmdzIAlzZXFfYXJnczsN
CiB9Ow0KIA0KQEAgLTYyNCw2ICs2MjMsNyBAQCBzdHJ1Y3QgbmZzX2dldGFjbHJlcyB7DQogCXNp
emVfdAkJCQlhY2xfbGVuOw0KIAlzaXplX3QJCQkJYWNsX2RhdGFfb2Zmc2V0Ow0KIAlpbnQJCQkJ
YWNsX2ZsYWdzOw0KKwlzdHJ1Y3QgcGFnZSAqCQkJYWNsX3NjcmF0Y2g7DQogCXN0cnVjdCBuZnM0
X3NlcXVlbmNlX3JlcwlzZXFfcmVzOw0KIH07DQogDQotLSANCjEuNy43LjYNCg0KDQotLSANClRy
b25kIE15a2xlYnVzdA0KTGludXggTkZTIGNsaWVudCBtYWludGFpbmVyDQoNCk5ldEFwcA0KVHJv
bmQuTXlrbGVidXN0QG5ldGFwcC5jb20NCnd3dy5uZXRhcHAuY29tDQoNCg==

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: oops when copying a file from a nfs mount
  2012-02-03 23:24   ` Koen Wilde
@ 2012-02-04  0:11     ` J. Bruce Fields
  0 siblings, 0 replies; 6+ messages in thread
From: J. Bruce Fields @ 2012-02-04  0:11 UTC (permalink / raw)
  To: Koen Wilde; +Cc: Neil Brown, linux-nfs, Andy Adamson

On Sat, Feb 04, 2012 at 12:24:27AM +0100, Koen Wilde wrote:
> On Fri, 3 Feb 2012 18:08:11 -0500, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> > 
> > Is this really the start of the trace, or were there any lines before?
> > 
> 
> This is really the start of the trace as it appears in syslog's logs. On
> the physical screen it had some extra lines on top though (I'm typing this
> over from a photo):
> 
>     BUG: unable to handle kernel NULL pointer dereference at   (null)
>     IP: [<c01f3c00>] page_address+0x10/0xe0
>     << continuing from here with the *pde line >>
> 
> > But I take it you're comfortable building a kernel from source?  If so,
> > getting a stable git repo, then:
> > 
> > 	git checkout v3.2.2
> > 	git revert 628fc192adbaae0c6178b9015fb916ce61d72b36
> > 
> > and then testing the resulting kernel--it'd be interesting to know if
> > the bug goes away.
> 
> Sure, I can build a kernel from source:) I'll get back to you with the
> results.

OK, but--probably ignore my suggestion and try applying Trond's patch
instead....

(Also, I assume mainline needs it as well as v3.2.2 ?)

--b.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: oops when copying a file from a nfs mount
  2012-02-03 23:45   ` Myklebust, Trond
@ 2012-02-04 13:37     ` Koen Wilde
  0 siblings, 0 replies; 6+ messages in thread
From: Koen Wilde @ 2012-02-04 13:37 UTC (permalink / raw)
  To: Myklebust, Trond, J. Bruce Fields
  Cc: Neil Brown, linux-nfs@vger.kernel.org, Adamson, Andy

On Fri, 3 Feb 2012 23:45:12 +0000, "Myklebust, Trond" <Trond.Myklebust@netapp.com> wrote:
> It is obvious: firstly acl_scratch is only needed (and allocated) if the
> npages > 1. Secondly, the call to xdr_set_scratch_buffer() needs to be
> done in the decoder, not the encoder...
> 
> The following patch should fix it.
> 
I can confirm the oops indeed doesn't occur anymore after applying this patch
to v3.2.2 :)

-- Koen

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-02-04 13:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-03 22:36 oops when copying a file from a nfs mount koen
2012-02-03 23:08 ` J. Bruce Fields
2012-02-03 23:24   ` Koen Wilde
2012-02-04  0:11     ` J. Bruce Fields
2012-02-03 23:45   ` Myklebust, Trond
2012-02-04 13:37     ` Koen Wilde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).