From: Christoph Hellwig <hch@infradead.org>
To: Steve Dickson <steved@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] SUNRPC: Add trace events to the sunrpc subsystem
Date: Mon, 6 Feb 2012 12:47:43 -0500 [thread overview]
Message-ID: <20120206174742.GA10427@infradead.org> (raw)
In-Reply-To: <1328540888-30109-2-git-send-email-steved@redhat.com>
> + TP_STRUCT__entry(
> + __field(const struct rpc_clnt *, clnt)
> + __field(const struct rpc_task *, task)
> + __field(const void *, action)
> + __field(unsigned long, runstate)
> + __field(int, status)
> + __field(unsigned short, flags)
Storing pointers in the trace buffer is not safe for reuse later,
and just printing the pointer values isn't overly useful either. Please
redesign these tracepoint to be a bit more useful.
next prev parent reply other threads:[~2012-02-06 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 15:08 [PATCH v3 0/2] SUNRPC: Added Tracing Points Steve Dickson
2012-02-06 15:08 ` [PATCH v3 1/2] SUNRPC: Add trace events to the sunrpc subsystem Steve Dickson
2012-02-06 17:47 ` Christoph Hellwig [this message]
2012-02-06 18:21 ` Myklebust, Trond
2012-02-06 15:08 ` [PATCH v3 2/2] SUNRPC: Adding status trace points Steve Dickson
2012-02-06 15:39 ` Myklebust, Trond
2012-02-06 17:30 ` Steve Dickson
-- strict thread matches above, loose matches on Subject: below --
2012-01-24 20:51 [PATCH 0/2] SUNRPC: Added Tracing Points Steve Dickson
2012-01-24 20:51 ` [PATCH v3 1/2] SUNRPC: Add trace events to the sunrpc subsystem Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206174742.GA10427@infradead.org \
--to=hch@infradead.org \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).