From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: Vitaliy Gusev <gusev.vitaliy@nexenta.com>,
"Adamson, Andy" <William.Adamson@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table()
Date: Tue, 14 Feb 2012 19:53:15 -0500 [thread overview]
Message-ID: <20120215005315.GA9018@fieldses.org> (raw)
In-Reply-To: <1329266587.28837.4.camel@lade.trondhjem.org>
On Wed, Feb 15, 2012 at 12:43:08AM +0000, Myklebust, Trond wrote:
> Then we have a problem. The zero initialisation is already in use out
> there in both commercial and non-commercial versions of Linux. It is too
> late to change that now.
>
> Furthermore, since none of the servers we've tested against in earlier
> Bakeathons and Connectathons have complained, I suggest that we rather
> change the spec with an errata.
Argh.
I just noticed that the server was crashing intermittently and traced it
to incorrect handling of the case where the client sends a one-op
SEQUENCE compound with seqid 0. I'm not sure why it started popping up
just in 3.3--perhaps some change in the way the client uses slots made
that more likely.
The server code actually looks like it did assume initial seqid 1, but
accepted initial seqid 0 (except in this one case) basically by mistake.
In any case, I think it should be easy enough to teach it just to accept
any seqid on a previously unused slot, so I'll do that....
--b.
next prev parent reply other threads:[~2012-02-15 0:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 21:48 [PATCH] nfs41: Initialize slot->seq_nr at nfs4_init_slot_table() Vitaliy Gusev
2012-02-14 22:46 ` Myklebust, Trond
2012-02-15 0:34 ` Vitaliy Gusev
2012-02-15 0:43 ` Myklebust, Trond
2012-02-15 0:53 ` J. Bruce Fields [this message]
2012-02-15 1:50 ` Myklebust, Trond
2012-02-15 2:30 ` Myklebust, Trond
2012-02-15 14:11 ` Vitaliy Gusev
2012-02-15 15:07 ` Adamson, Andy
2012-02-15 15:46 ` Myklebust, Trond
2012-02-15 16:06 ` Andy Adamson
2012-02-15 18:37 ` Myklebust, Trond
2012-02-15 18:45 ` Adamson, Andy
2012-02-15 15:01 ` Adamson, Andy
2012-02-15 15:06 ` Vitaliy Gusev
2012-02-15 15:16 ` Andy Adamson
2012-02-15 15:27 ` Vitaliy Gusev
2012-02-15 15:29 ` Myklebust, Trond
2012-02-15 15:45 ` Andy Adamson
2012-02-15 15:52 ` J. Bruce Fields
2012-02-15 15:15 ` Andy Adamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215005315.GA9018@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=gusev.vitaliy@nexenta.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).