From: Chuck Lever <chuck.lever@oracle.com>
To: trond.myklebust@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 02/13] NFS: Fix comparison signage warnings with slot ID computations
Date: Wed, 15 Feb 2012 16:35:00 -0500 [thread overview]
Message-ID: <20120215213500.3254.16678.stgit@ellison.1015granger.net> (raw)
In-Reply-To: <20120215213336.3254.98936.stgit@ellison.1015granger.net>
To make nfs4proc.c compile cleanly, address the following compiler
warnings:
fs/nfs/nfs4proc.c: In function ‘nfs4_free_slot’:
fs/nfs/nfs4proc.c:371:2: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
fs/nfs/nfs4proc.c: In function ‘nfs4_reset_slot_table’:
fs/nfs/nfs4proc.c:5000:15: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
fs/nfs/nfs4proc.c: In function ‘nfs4_init_slot_table’:
fs/nfs/nfs4proc.c:5064:2: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare]
Why is max_reqs always u32, but nfs4_slot_table.max_slots a signed
integer?
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfs/nfs4proc.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index d9f4d78..5ff9c5a 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -368,7 +368,7 @@ nfs4_free_slot(struct nfs4_slot_table *tbl, struct nfs4_slot *free_slot)
int free_slotid = free_slot - tbl->slots;
int slotid = free_slotid;
- BUG_ON(slotid < 0 || slotid >= NFS4_MAX_SLOT_TABLE);
+ BUG_ON(slotid < 0 || slotid >= (int)NFS4_MAX_SLOT_TABLE);
/* clear used bit in bitmap */
__clear_bit(slotid, tbl->used_slots);
@@ -4997,7 +4997,7 @@ static int nfs4_reset_slot_table(struct nfs4_slot_table *tbl, u32 max_reqs,
max_reqs, tbl->max_slots);
/* Does the newly negotiated max_reqs match the existing slot table? */
- if (max_reqs != tbl->max_slots) {
+ if (max_reqs != (u32)tbl->max_slots) {
ret = -ENOMEM;
new = kmalloc(max_reqs * sizeof(struct nfs4_slot),
GFP_NOFS);
@@ -5056,7 +5056,7 @@ static void nfs4_destroy_slot_tables(struct nfs4_session *session)
* Initialize slot table
*/
static int nfs4_init_slot_table(struct nfs4_slot_table *tbl,
- int max_slots, int ivalue)
+ u32 max_slots, int ivalue)
{
struct nfs4_slot *slot;
int ret = -ENOMEM;
next prev parent reply other threads:[~2012-02-15 21:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 21:34 [PATCH 00/13] For 3.4 (try 2) Chuck Lever
2012-02-15 21:34 ` [PATCH 01/13] NFS: Make nfs_cache_array.size a signed integer Chuck Lever
2012-02-16 19:52 ` Myklebust, Trond
2012-02-16 20:09 ` Chuck Lever
2012-02-16 20:34 ` Myklebust, Trond
2012-02-16 20:53 ` Chuck Lever
2012-02-15 21:35 ` Chuck Lever [this message]
2012-02-16 19:52 ` [PATCH 02/13] NFS: Fix comparison signage warnings with slot ID computations Myklebust, Trond
2012-02-16 20:10 ` Chuck Lever
2012-02-15 21:35 ` [PATCH 03/13] SUNRPC: Use KERN_DEFAULT for debugging printk's Chuck Lever
2012-02-15 22:05 ` Malahal Naineni
2012-02-16 19:54 ` Myklebust, Trond
2012-02-15 21:35 ` [PATCH 04/13] nfs: Clean up debugging in nfs_follow_mountpoint() Chuck Lever
2012-02-15 21:35 ` [PATCH 05/13] NFS: Clean up debugging in decode_pathname() Chuck Lever
2012-02-15 21:35 ` [PATCH 06/13] NFS: Add debugging messages to NFSv4's CLOSE procedure Chuck Lever
2012-02-15 21:35 ` [PATCH 07/13] NFS: Reduce debugging noise from encode_compound_hdr Chuck Lever
2012-02-16 20:04 ` Myklebust, Trond
2012-02-16 20:11 ` Chuck Lever
2012-02-15 21:35 ` [PATCH 08/13] SUNRPC: Add API to acquire source address Chuck Lever
2012-02-15 22:12 ` Malahal Naineni
2012-02-15 22:17 ` Chuck Lever
2012-02-16 20:07 ` Myklebust, Trond
2012-02-16 20:13 ` Chuck Lever
2012-02-15 21:36 ` [PATCH 09/13] NFS: Add a client-side function to display NFS file handles Chuck Lever
2012-02-15 21:36 ` [PATCH 10/13] NFS: Save root file handle in nfs_server Chuck Lever
2012-02-15 21:36 ` [PATCH 11/13] NFS: Simplify arguments of encode_renew() Chuck Lever
2012-02-15 21:36 ` [PATCH 12/13] NFS: Introduce NFS_ATTR_FATTR_V4_LOCATIONS Chuck Lever
2012-02-15 21:36 ` [PATCH 13/13] NFS: Request fh_expire_type attribute in "server caps" operation Chuck Lever
2012-02-20 15:01 ` Matthew Treinish
-- strict thread matches above, loose matches on Subject: below --
2012-02-15 19:41 [PATCH 00/13] For 3.4 Chuck Lever
2012-02-15 19:41 ` [PATCH 02/13] NFS: Fix comparison signage warnings with slot ID computations Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215213500.3254.16678.stgit@ellison.1015granger.net \
--to=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).