Re: [PATCH 03/13] SUNRPC: Use KERN_DEFAULT for debugging printk's

[Malahal Naineni <malahal@us.ibm.com>]

Most of the dprintk() callers are using __func__. Not sure if adding
that to the dprintk itself is a good idea. In any case, it will have to
be a separate patchset though.

Regards, Malahal.

Chuck Lever [chuck.lever@oracle.com] wrote:
> Our dprintk() debugging facility doesn't specify any verbosity level
> for it's printk() calls, but it should.
> 
> The default verbosity for printk's is KERN_DEFAULT.  You might argue
> that these are debugging printk's and thus the verbosity should be
> KERN_DEBUG.  That would mean that to see NFS and SUNRPC debugging
> output an admin would also have to boost the syslog verbosity, which
> would be insufferably noisy.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  include/linux/sunrpc/debug.h |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/include/linux/sunrpc/debug.h b/include/linux/sunrpc/debug.h
> index c2786f2..e0927c2 100644
> --- a/include/linux/sunrpc/debug.h
> +++ b/include/linux/sunrpc/debug.h
> @@ -51,7 +51,11 @@ extern unsigned int		nlm_debug;
>  #undef ifdebug
>  #ifdef RPC_DEBUG			
>  # define ifdebug(fac)		if (unlikely(rpc_debug & RPCDBG_##fac))
> -# define dfprintk(fac, args...)	do { ifdebug(fac) printk(args); } while(0)
> +# define dfprintk(fac, args...)	\
> +	do { \
> +		ifdebug(fac) \
> +			printk(KERN_DEFAULT args); \
> +	} while (0)
>  # define RPC_IFDEBUG(x)		x
>  #else
>  # define ifdebug(fac)		if (0)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>