linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: steve <steve@steve-ss.com>
Cc: Jeff Layton <jlayton@poochiereds.net>, linux-nfs@vger.kernel.org
Subject: Re: POSIX acls over nfs4
Date: Thu, 23 Feb 2012 09:40:53 -0500	[thread overview]
Message-ID: <20120223144053.GA25010@fieldses.org> (raw)
In-Reply-To: <4F4628B8.90401@steve-ss.com>

On Thu, Feb 23, 2012 at 12:53:28PM +0100, steve wrote:
> Hi Jeff
> Thanks for the reply. I'm trying to make the files created in a
> share take on group rw.
> 
> The trouble is that I've already tried setting the acl's via
> nfs4_setfacl on the mounted share too (please see details below).
> The acl + appears on the unmounted share and behaves as expected
> even when it is not mounted. The mounted share however ignores the
> acl I've set. I've tried remounting but still no acl is effective.
> My workaround is to scan the folder and change the files to group rw
> every few seconds.

Without looking at your details, apologies:

First, if you want an ace on a directory to be inherited by files and
directories created under that directory, make sure you're setting the f
and d flags (see nfs4_getfacl -H).

Second, there's a umask problem: posix acl inheritance overrides the
umask, but nfs4 acl inheritance isn't doing that.  (The client combines
the create mode and the umask and sets both together, there's no way for
the server to even tell what the umask is.)

(We should do something about this if we can: maybe modifying the client
to scan the directory acl for any inheritable aces and leaving out the
umask if they're found?  It has the obvious race, but I seem to recall
we live with that in the v3 case.  Or maybe there's something more
clever, but this comes up every now and then and I can't remember a
better solution.)

--b.

  reply	other threads:[~2012-02-23 14:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-18 20:08 POSIX acls over nfs4 steve
2012-02-19 17:15 ` steve
2012-02-23  7:15   ` steve
2012-02-23  8:33     ` tao.peng
2012-02-23 12:50       ` steve
2012-02-23 11:39     ` Jeff Layton
2012-02-23 11:53       ` steve
2012-02-23 14:40         ` J. Bruce Fields [this message]
2012-02-23 15:33           ` steve
2012-02-23 15:42             ` J. Bruce Fields
2012-02-23 16:08               ` steve
2012-02-25  8:19                 ` steve
2012-02-28 20:05                   ` J. Bruce Fields
2012-02-28 23:22                     ` steve
2012-02-29 12:44                       ` J. Bruce Fields
2012-02-29 14:04                         ` steve
2012-02-29 14:09                           ` J. Bruce Fields
2012-02-29 14:26                             ` steve
2012-02-29 14:32                               ` J. Bruce Fields
2012-02-29 14:40                                 ` steve
2012-03-01 20:56                                   ` J. Bruce Fields
2012-03-01 22:11                                     ` steve
2012-03-02 18:03                                       ` J. Bruce Fields
2012-02-28 20:00                 ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120223144053.GA25010@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=steve@steve-ss.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).