From: Dan Carpenter <dan.carpenter@oracle.com>
To: chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: re: NFS: Add a client-side function to display NFS file handles
Date: Tue, 6 Mar 2012 13:51:35 +0300 [thread overview]
Message-ID: <20120306105134.GA1048@elgon.mountain> (raw)
Hello Chuck Lever,
This is a semi-automatic email about new static checker warnings.
The patch 20d27e929fb4: "NFS: Add a client-side function to display
NFS file handles" from Mar 1, 2012, leads to the following Smatch
complaint:
fs/nfs/inode.c:1061 _nfs_display_fhandle()
warn: variable dereferenced before check 'fh' (see line 1061)
fs/nfs/inode.c
1060
1061 if (fh->size == 0 || fh == NULL) {
^^^^^^^^ ^^^^^^^^^^
dereference check
1062 printk(KERN_DEFAULT "%s at %p is empty\n", caption, fh);
1063 return;
regards,
dan carpenter
next reply other threads:[~2012-03-06 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 10:51 Dan Carpenter [this message]
2012-03-06 16:14 ` Fwd: NFS: Add a client-side function to display NFS file handles Chuck Lever
2012-03-06 16:18 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306105134.GA1048@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).