From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Adamson, Andy" <William.Adamson@netapp.com>
Cc: "Myklebust, Trond" <Trond.Myklebust@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/3] NFSv4.1: Fix the checking of the stateid when returning a delegation
Date: Tue, 6 Mar 2012 13:20:27 -0500 [thread overview]
Message-ID: <20120306182027.GA24416@fieldses.org> (raw)
In-Reply-To: <0A25AB17-8DC0-4524-A276-2BB1B80348C5@netapp.com>
On Tue, Mar 06, 2012 at 03:13:37PM +0000, Adamson, Andy wrote:
>
> On Mar 6, 2012, at 9:57 AM, Myklebust, Trond wrote:
>
> > On Tue, 2012-03-06 at 09:46 -0500, andros@netapp.com wrote:
> >> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> >>
> >> nfs41_validate_delegation_stateid is broken if we supply a stateid with
> >> a non-zero sequence id. Instead of trying to match the sequence id,
> >> the function assumes that we always want to error. While this is
> >> true for a delegation callback, it is not true in general.
> >>
> >> Also fix a typo in nfs4_callback_recall.
> >>
> >> Reported-by: Andy Adamson <andros@netapp.com>
> >> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> >
> > Did you really intend to Cc: stable on these before we've committed them
> > upstream?
>
> I guess I misunderstood when to add the Cc: stable.
Me too--I thought the stable folks would wait till they see a commit?
Though adding a Cc: line with the Signed-off-by's and leaving them out
of the email header would seem simpler.
--b.
next prev parent reply other threads:[~2012-03-06 18:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 14:46 [PATCH 0/3] NFS recover from delegation stateid error andros
2012-03-06 14:46 ` [PATCH 1/3] NFSv4.1: Fix the checking of the stateid when returning a delegation andros
2012-03-06 14:57 ` Myklebust, Trond
2012-03-06 15:13 ` Adamson, Andy
2012-03-06 18:20 ` J. Bruce Fields [this message]
2012-03-06 14:46 ` [PATCH 2/3] NFS: Properly handle the case where the delegation is revoked andros
2012-03-06 14:46 ` [PATCH 3/3] NFSv4.1 do not clear NFS_DELEAGED_STATE until stateid is tested andros
2012-03-06 14:53 ` Myklebust, Trond
2012-03-06 14:55 ` Andy Adamson
2012-03-06 15:12 ` Andy Adamson
2012-03-06 15:17 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120306182027.GA24416@fieldses.org \
--to=bfields@fieldses.org \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).