From: Dan Carpenter <dan.carpenter@oracle.com>
To: andros@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: re: NFSv4.1 handle DS stateid errors
Date: Thu, 8 Mar 2012 13:05:17 +0300 [thread overview]
Message-ID: <20120308100517.GA31881@elgon.mountain> (raw)
Hello Andy Adamson,
This is a semi-automatic email about new static checker warnings.
The patch 9cb8196839ab: "NFSv4.1 handle DS stateid errors" from Mar
7, 2012, leads to the following Smatch complaint:
fs/nfs/nfs4filelayout.c:102 filelayout_async_handle_error()
warn: variable dereferenced before check 'state' (see line 90)
fs/nfs/nfs4filelayout.c
89 {
90 struct nfs_server *mds_server = NFS_SERVER(state->inode);
^^^^^^^^^^^^
new dereference.
91 struct nfs_client *mds_client = mds_server->nfs_client;
92
93 if (task->tk_status >= 0)
94 return 0;
95 *reset = 0;
96
97 switch (task->tk_status) {
98 /* MDS state errors */
99 case -NFS4ERR_DELEG_REVOKED:
100 case -NFS4ERR_ADMIN_REVOKED:
101 case -NFS4ERR_BAD_STATEID:
102 if (state != NULL)
^^^^^^^^^^^^^
new check.
103 nfs_remove_bad_delegation(state->inode);
104 case -NFS4ERR_OPENMODE:
regards,
dan carpenter
reply other threads:[~2012-03-08 10:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120308100517.GA31881@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=andros@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox