From: Al Viro <viro@ZenIV.linux.org.uk>
To: Boaz Harrosh <bharrosh@panasas.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
NFS list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] pnfs-obj: Uglify objio_segment allocation for the sake of the principle :-(
Date: Wed, 14 Mar 2012 05:15:09 +0000 [thread overview]
Message-ID: <20120314051509.GH23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4F60141A.709@panasas.com>
On Tue, Mar 13, 2012 at 08:44:26PM -0700, Boaz Harrosh wrote:
> +/* This is the in memory structure of the objio_segment
> + *
> + * struct __alloc_objio_segment {
> + * struct objio_segment olseg;
> + * struct ore_dev *ods[numdevs];
> + * struct ore_comp comps[numdevs];
> + * } *aolseg;
> + * NOTE: The code as above compiles and runs perfectly. It is elegant,
> + * type safe and compact.
In which type system? Not C99 - there variably-modified types are not
allowed as structure or union members...
next prev parent reply other threads:[~2012-03-14 5:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 3:44 [PATCH] pnfs-obj: Uglify objio_segment allocation for the sake of the principle :-( Boaz Harrosh
2012-03-14 4:37 ` Linus Torvalds
2012-03-14 18:33 ` Boaz Harrosh
2012-03-14 5:15 ` Al Viro [this message]
2012-03-14 18:57 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120314051509.GH23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Trond.Myklebust@netapp.com \
--cc=bharrosh@panasas.com \
--cc=linux-nfs@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox