From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH v10 1/8] nfsd: convert nfs4_client->cl_cb_flags to a generic flags field
Date: Wed, 21 Mar 2012 17:05:34 -0400 [thread overview]
Message-ID: <20120321210532.GD12309@fieldses.org> (raw)
In-Reply-To: <20120321165244.4ed5977e@redhat.com>
On Wed, Mar 21, 2012 at 04:52:44PM -0400, Jeff Layton wrote:
> On Wed, 21 Mar 2012 16:41:42 -0400
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
>
> > On Wed, Mar 21, 2012 at 09:52:02AM -0400, Jeff Layton wrote:
> > > @@ -2779,12 +2780,6 @@ static void
> > > nfs4_set_claim_prev(struct nfsd4_open *open, bool has_session)
> > > {
> > > open->op_openowner->oo_flags |= NFS4_OO_CONFIRMED;
> > > - /*
> > > - * On a 4.1+ client, we don't create a state record for a client
> > > - * until it performs RECLAIM_COMPLETE:
> > > - */
> > > - if (!has_session)
> > > - open->op_openowner->oo_owner.so_client->cl_firststate = 1;
> >
> > That doesn't look right. Sure you didn't mean to just make that a
> > set_bit, at least for now?
> >
> > --b.
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> No. I think that's correct. Once the RECLAIM_COMPLETE is done, we'll
> create a client record and then the NFSD4_CLIENT_STABLE flag will be
> set. We clearly don't want to set that flag until the client is
> actually recorded onto stable storage.
>
> One of the goals of this patch was to get rid of cl_firststate which
> had a very ambiguous meaning. NFSD4_CLIENT_STABLE now means that the
> client is recorded on stable storage, full stop.
>
> Did I miss some subtlety that we'll need to account for in the state
> model here?
Oh, I see, I missed that nfsd4_client_record_check is setting the flag
where I think it wouldn't have been before.
This does look cleaner, thanks!
--b.
next prev parent reply other threads:[~2012-03-21 21:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 13:52 [PATCH v10 0/8] nfsd: overhaul the client name tracking code Jeff Layton
2012-03-21 13:52 ` [PATCH v10 1/8] nfsd: convert nfs4_client->cl_cb_flags to a generic flags field Jeff Layton
2012-03-21 20:41 ` J. Bruce Fields
2012-03-21 20:52 ` Jeff Layton
2012-03-21 21:05 ` J. Bruce Fields [this message]
2012-03-21 13:52 ` [PATCH v10 2/8] nfsd: add nfsd4_client_tracking_ops struct and a way to set it Jeff Layton
2012-03-21 20:42 ` [PATCH v11 " Jeff Layton
2012-03-21 23:59 ` [PATCH v10 " Jeff Layton
2012-03-21 13:52 ` [PATCH v10 3/8] sunrpc: create nfsd dir in rpc_pipefs Jeff Layton
2012-03-23 12:12 ` J. Bruce Fields
2012-03-23 13:31 ` J. Bruce Fields
2012-03-23 15:20 ` Myklebust, Trond
2012-03-23 15:22 ` J. Bruce Fields
2012-03-23 15:34 ` Myklebust, Trond
2012-03-23 15:53 ` Jeff Layton
2012-03-23 16:12 ` Jeff Layton
2012-03-23 17:04 ` J. Bruce Fields
2012-03-28 23:09 ` [PATCH] nfsd4: use auth_unix unconditionally on backchannel J. Bruce Fields
2012-03-28 23:16 ` Myklebust, Trond
2012-03-28 23:46 ` J. Bruce Fields
2012-03-29 14:29 ` Matt W. Benjamin
2012-03-29 14:29 ` Matt W. Benjamin
2012-03-29 14:48 ` J. Bruce Fields
2012-03-23 16:00 ` [PATCH v10 3/8] sunrpc: create nfsd dir in rpc_pipefs J. Bruce Fields
2012-03-21 13:52 ` [PATCH v10 4/8] nfsd: add a per-net-namespace struct for nfsd Jeff Layton
2012-03-21 13:52 ` [PATCH v10 5/8] nfsd: add a header describing upcall to nfsdcld Jeff Layton
2012-03-21 13:52 ` [PATCH v10 6/8] nfsd: add the infrastructure to handle the cld upcall Jeff Layton
2012-03-21 13:52 ` [PATCH v10 7/8] nfsd: add notifier to handle mount/unmount of rpc_pipefs sb Jeff Layton
2012-03-21 13:52 ` [PATCH v10 8/8] nfsd: don't allow legacy client tracker init for anything but init_net Jeff Layton
2012-03-23 17:06 ` [PATCH v10 0/8] nfsd: overhaul the client name tracking code J. Bruce Fields
2012-03-23 17:26 ` Jeff Layton
2012-03-26 20:02 ` J. Bruce Fields
2012-03-27 15:06 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120321210532.GD12309@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox