Re: [PATCH 20/20] NFS: Clean up debugging messages in fs/nfs/client.c

[Malahal Naineni <malahal@us.ibm.com>]

Chuck Lever [chuck.lever@oracle.com] wrote:
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  fs/nfs/client.c |   21 +++++++++++++++++----
>  1 files changed, 17 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 7330673..beb001b 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -192,6 +192,8 @@ static struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_
>  		clp->cl_machine_cred = cred;
>  	nfs_fscache_get_client_cookie(clp);
> 
> +	dprintk("NFS: %s returning new nfs_client = %p ({1})\n",
> +		__func__, clp);
>  	return clp;
> 
>  error_cleanup:
> @@ -291,7 +293,7 @@ static void pnfs_init_server(struct nfs_server *server)
>   */
>  static void nfs_free_client(struct nfs_client *clp)
>  {
> -	dprintk("--> nfs_free_client(%u)\n", clp->rpc_ops->version);
> +	dprintk("--> %s destroying nfs_client = %p\n", __func__, clp);
> 
>  	nfs4_shutdown_client(clp);
> 
> @@ -308,7 +310,7 @@ static void nfs_free_client(struct nfs_client *clp)
>  	kfree(clp->cl_hostname);
>  	kfree(clp);
> 
> -	dprintk("<-- nfs_free_client()\n");
> +	dprintk("<-- %s done\n", __func__);

Many dprintk's seem to take __func__. How about pushing that to dprink
macro itself. I have one and use it most of the time.

Regards, Malahal.